fix: move NotificationsService to parent MatchEventProcessor#135
Open
fix: move NotificationsService to parent MatchEventProcessor#135
Conversation
Without @Injectable() on the child class, NestJS cannot generate design:paramtypes metadata for the child's constructor. It falls back to the parent's metadata (4 params), so the 5th param (NotificationsService) is never injected, causing a TypeError when sendMatchMapPauseNotification is called during match map pause events.
Contributor
|
so this will also cause moe memory usage, we might want to just add notification service on to the parent class. the request scope means each time it comes into will generate the notification service (new) each time. |
Contributor
|
TLDR; just add the notification service to the parent |
Instead of adding @Injectable to the child class, move NotificationsService into the parent constructor so all event processors can access it without needing their own decorator. Also removes redundant constructors from MatchMapStatusEvent and MatchMapResetRoundEvent.
Contributor
Author
|
@lukepolo Updated:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotificationsServiceinto the parentMatchEventProcessorconstructor so all event processors inherit itthis.notificationsbeingundefinedinMatchMapStatusEvent, which crashed withTypeError: Cannot read properties of undefined (reading 'sendMatchMapPauseNotification')when a match map entered "Paused" statusMatchMapStatusEventandMatchMapResetRoundEventto align with sibling event classesTest plan