This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Conversation
ESLint Summary View Full Report
Report generated by eslint-plus-action |
DaniSomoza
approved these changes
Jul 12, 2022
58c7c67 to
8e4b0bb
Compare
This reverts commit 5965f27.
8e4b0bb to
6494f08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid a mini infinite loop I'm facing in transaction builder I added a check for address/input value equality before firing
updateAddressState.The mini infinite loop looks like following:
address(passed from controlling component) = '',inputValue= "ABC" -->onChangeAddressis calledaddress(passed from controlling component) = 'ABC',inputValue= "ABC" -->updateAddressStateis called becauseaddresshas changed, and it callsonChangeAddressagainI also disabled webpack minimizing because this is a developer-facing library and it's way cooler to debug non-minified code