Skip to content

feat: Add option to toggle scale bar#733

Merged
Czaki merged 2 commits into
developfrom
feature/add_scale_bar
Sep 30, 2022
Merged

feat: Add option to toggle scale bar#733
Czaki merged 2 commits into
developfrom
feature/add_scale_bar

Conversation

@Czaki

@Czaki Czaki commented Sep 30, 2022

Copy link
Copy Markdown
Collaborator

Add an option to enable the toggle scale bar in the View menu.

@sourcery-ai

sourcery-ai Bot commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.14%.

Quality metrics Before After Change
Complexity 3.73 ⭐ 3.71 ⭐ -0.02 👍
Method Length 88.69 🙂 87.69 🙂 -1.00 👍
Working memory 8.33 🙂 8.30 🙂 -0.03 👍
Quality 63.41% 🙂 63.55% 🙂 0.14% 👍
Other metrics Before After Change
Lines 2344 2354 10
Changed files Quality Before Quality After Quality Change
package/PartSeg/_roi_analysis/main_window.py 61.00% 🙂 61.20% 🙂 0.20% 👍
package/PartSeg/_roi_mask/main_window.py 63.81% 🙂 63.93% 🙂 0.12% 👍
package/PartSeg/common_gui/napari_image_view.py 64.59% 🙂 64.73% 🙂 0.14% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSeg/_roi_mask/main_window.py MainMenu.load_segmentation 19 😞 240 ⛔ 33.34% 😞 Refactor to reduce nesting. Try splitting into smaller methods
package/PartSeg/_roi_mask/main_window.py AlgorithmOptions.__init__ 0 ⭐ 895 ⛔ 22 ⛔ 36.39% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/_roi_analysis/main_window.py Options.__init__ 0 ⭐ 593 ⛔ 17 ⛔ 39.94% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/_roi_mask/main_window.py MainMenu.save_result 11 🙂 277 ⛔ 40.55% 😞 Try splitting into smaller methods
package/PartSeg/common_gui/napari_image_view.py ImageView.print_info 19 😞 178 😞 11 😞 41.13% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@deprecated-napari-hub-preview-bot

deprecated-napari-hub-preview-bot Bot commented Sep 30, 2022

Copy link
Copy Markdown

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/733
Updated: 2022-09-30T19:03:58.528093

@codecov

codecov Bot commented Sep 30, 2022

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (develop@87dab17). Click here to learn what that means.
Patch coverage: 36.36% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #733   +/-   ##
==========================================
  Coverage           ?   88.58%           
==========================================
  Files              ?      190           
  Lines              ?    29344           
  Branches           ?        0           
==========================================
  Hits               ?    25994           
  Misses             ?     3350           
  Partials           ?        0           
Impacted Files Coverage Δ
package/PartSeg/_roi_mask/main_window.py 63.93% <25.00%> (ø)
package/PartSeg/common_gui/napari_image_view.py 84.79% <33.33%> (ø)
package/PartSeg/_roi_analysis/main_window.py 59.00% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Czaki Czaki merged commit 531e0f6 into develop Sep 30, 2022
@Czaki Czaki deleted the feature/add_scale_bar branch September 30, 2022 22:01
@Czaki Czaki added this to the v0.14.4 milestone Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant