chore: Remove `pyside2` form extras during constraints generation by Czaki · Pull Request #1411 · 4DNucleome/PartSeg

Czaki · 2026-06-09T08:26:38Z

The pyside2no longer have releases and is about to remove from project (as napari 0.7.0 changed bundle to PySide6)

Summary by Sourcery

CI:

Remove the pyside2 extra from the upgrade-dependencies workflow when compiling constraints.

Summary by CodeRabbit

Chores
- Updated the automated dependency upgrade workflow configuration to use updated Python UI library options.

The `pyside2`no longer have releases and is about to remove from project (as napari 0.7.0 changed bundle to `PySide6`)

sourcery-ai · 2026-06-09T08:26:44Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the dependency constraints generation workflow to stop including the deprecated pyside2 extra, aligning constraints with the current supported GUI backends.

File-Level Changes

Change	Details	Files
Stop generating constraints for the deprecated pyside2 extra in the upgrade-dependencies workflow.	Remove the `--extra pyside2` flag from the `flags` array used for constraints generation Ensure the constraints compilation loop now only targets pyqt6, pyside6, test, and pyinstaller_base extras	`.github/workflows/upgrade-dependencies.yml`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

coderabbitai · 2026-06-09T08:26:45Z

📝 Walkthrough

Walkthrough

This PR updates the Python dependency constraint compilation workflow step, replacing the pyside2 extra with pyside6 while retaining pyqt6 in the compilation flags.

Changes

Dependency Compilation Extras

Layer / File(s)	Summary
Update extras flags in constraint compilation `.github/workflows/upgrade-dependencies.yml`	The `uv pip compile` step updates the extras array to include `--extra pyqt6` and `--extra pyside6`, replacing `--extra pyside2`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

4DNucleome/PartSeg#1215: Both PRs modify the same workflow constraint compilation step, changing extras flags and resulting constraint output filenames.
4DNucleome/PartSeg#1157: Aligned goal of updating install constraints for Qt packages, with this PR swapping pyside2 for pyside6 in the dependency compilation extras.

Poem

🐰 From pyside2 to pyside6, what a switch!
Qt extras now shimmer, oh so rich,
Constraints compiled fresh, the workflow's delight,
One tiny line makes the dependencies right! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing pyside2 from extras during constraints generation in the workflow.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix_dependecies

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sourcery-ai

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

sonarqubecloud · 2026-06-09T08:27:15Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Czaki · 2026-06-09T09:44:04Z

@coderabbitai review

coderabbitai · 2026-06-09T09:44:10Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

🧹 Nitpick comments (1)

.github/workflows/upgrade-dependencies.yml (1)
36-36: Adjust scope: pyside alias doesn’t affect the workflow’s constraint generation

The workflow generates constraints with --extra pyside6 (not --extra pyside), and there’s no usage of PartSeg[pyside] / --extra pyside elsewhere in the repo. So pyproject.toml’s pyside = ["PartSeg[pyside2]"] is not an active contract mismatch with the current constraints-generation step.

Optional: if you intend the generic pyside extra to mean “current” backend (PySide6), consider renaming/updating that alias; otherwise leave it for the PySide2 legacy backend.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/upgrade-dependencies.yml at line 36, The workflow uses
flags=(--extra pyqt6 --extra pyside6 --extra test --extra pyinstaller_base)
while pyproject.toml defines pyside = ["PartSeg[pyside2]"], so the workflow’s
constraint generation targets pyside6 not the pyside alias; fix by making the
intent explicit: either add/replace --extra pyside in the flags tuple to match
the pyproject alias (flags (…) include --extra pyside) or update the
pyproject.toml alias pyside to reference the current backend (e.g., Point to
PartSeg[pyside6] or rename the alias to pyside2 if you intend the legacy
backend); update the symbol names flags, --extra pyside6, and the pyproject.toml
entry pyside = ["PartSeg[pyside2]"] accordingly.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/upgrade-dependencies.yml:
- Line 36: The workflow uses flags=(--extra pyqt6 --extra pyside6 --extra test
--extra pyinstaller_base) while pyproject.toml defines pyside =
["PartSeg[pyside2]"], so the workflow’s constraint generation targets pyside6
not the pyside alias; fix by making the intent explicit: either add/replace
--extra pyside in the flags tuple to match the pyproject alias (flags (…)
include --extra pyside) or update the pyproject.toml alias pyside to reference
the current backend (e.g., Point to PartSeg[pyside6] or rename the alias to
pyside2 if you intend the legacy backend); update the symbol names flags,
--extra pyside6, and the pyproject.toml entry pyside = ["PartSeg[pyside2]"]
accordingly.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 51c3f531-3f40-4b24-9173-20e82009e464

📥 Commits

Reviewing files that changed from the base of the PR and between 1ac2cb2 and b0bb253.

📒 Files selected for processing (1)

.github/workflows/upgrade-dependencies.yml

chore: Remove pyside2 form extras during constraints generation

b0bb253

The `pyside2`no longer have releases and is about to remove from project (as napari 0.7.0 changed bundle to `PySide6`)

Czaki added this to the 0.17.0 milestone Jun 9, 2026

sourcery-ai Bot reviewed Jun 9, 2026

View reviewed changes

Czaki added the skip check PR title skip spellcheking PR title label Jun 9, 2026

coderabbitai Bot reviewed Jun 9, 2026

View reviewed changes

Czaki merged commit bb02649 into develop Jun 9, 2026
59 of 61 checks passed

Czaki deleted the fix_dependecies branch June 9, 2026 23:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Remove `pyside2` form extras during constraints generation#1411

chore: Remove `pyside2` form extras during constraints generation#1411
Czaki merged 1 commit into
developfrom
fix_dependecies

Czaki commented Jun 9, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

sourcery-ai Bot commented Jun 9, 2026 •

edited

Loading

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

sonarqubecloud Bot commented Jun 9, 2026

Uh oh!

Czaki commented Jun 9, 2026

Uh oh!

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Czaki commented Jun 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Summary by CodeRabbit

Uh oh!

sourcery-ai Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

coderabbitai Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jun 9, 2026

Quality Gate passed

Uh oh!

Czaki commented Jun 9, 2026

Uh oh!

coderabbitai Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Czaki commented Jun 9, 2026 •

edited by coderabbitai Bot

Loading

sourcery-ai Bot commented Jun 9, 2026 •

edited

Loading

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading