-
Notifications
You must be signed in to change notification settings - Fork 10
chore: Drop python 3.8 #1206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Drop python 3.8 #1206
Changes from all commits
071109e
f8ebccf
82ca4f7
b68789d
3aacae8
86d423e
b4eb02e
d4f81f9
07918b8
44c8b76
96a20d2
4e7e31f
c06e15d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,7 @@ stages: | |
| displayName: "download data" | ||
| - task: UsePythonVersion@0 | ||
| inputs: | ||
| versionSpec: '3.9' | ||
| versionSpec: '3.11' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Potential Compatibility Issues with Python 3.11 The update to Python 3.11 may introduce compatibility issues due to existing version-specific checks in the codebase:
These checks indicate that the code is not currently designed to support Python versions above 3.10, which includes the proposed 3.11 update. Action Items:
🔗 Analysis chainApproved: Python version update in GetTestData stage The update from Python 3.9 to 3.11 in the To ensure this change doesn't introduce any compatibility issues, please verify:
You can use the following script to check for any Python version-specific code or dependencies in the repository: This script will help identify any potential compatibility issues that might arise from updating the Python version. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for Python version-specific code or dependencies
# Search for version-specific imports or syntax
echo "Checking for version-specific Python code:"
rg --type python 'import.*python3\.(8|9|10)' || echo "No version-specific imports found."
# Check requirements files for version-specific dependencies
echo "Checking requirements files for version-specific dependencies:"
rg --type-add 'requirements:*.txt' --type requirements '^python_version' || echo "No version-specific dependencies found in requirements files."
# Check for sys.version_info checks
echo "Checking for sys.version_info checks:"
rg --type python 'sys\.version_info' || echo "No sys.version_info checks found."
Length of output: 826 Script: #!/bin/bash
# Description: Check for Python version-specific code or dependencies
# Search for version-specific imports or syntax in Python files
echo "Checking for version-specific Python code:"
rg --glob '*.py' 'import.*python3\.(8|9|10)' || echo "No version-specific imports found."
# Check requirements files for version-specific dependencies
echo "Checking requirements files for version-specific dependencies:"
rg --glob 'requirements*.txt' '^python_version' || echo "No version-specific dependencies found in requirements files."
# Check for sys.version_info checks in Python files
echo "Checking for sys.version_info checks:"
rg --glob '*.py' 'sys\.version_info' || echo "No sys.version_info checks found."
Length of output: 1278 |
||
| displayName: 'Use Python $(python.version)' | ||
| - script: python build_utils/cut_changelog.py changelog_cut.md | ||
| displayName: "Cut changelog" | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Update Required: Workflow is not using the latest stable napari release.
The workflow is currently using
napari54mapped tov0.4.18, while the latest stable release of napari is0.5.4. To ensure that tests are run against the most recent stable version, consider updating the workflow to use napari0.5.4..github/workflows/test_napari_widgets.ymlto usenapari: "0.5.4"🔗 Analysis chain
Approve update to latest napari version.
The update from "napari5" to "napari54" for the latest release test is appropriate and aligns with the PR objective of updating dependencies.
To ensure we're testing against the most recent stable release, please run the following script:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where
napari5.4is mapped tov0.4.18?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Czaki, thank you for bringing this to my attention. I apologize for the confusion.
You're correct—
napari54corresponds to napari version0.5.4, notv0.4.18as I previously mentioned.Therefore, your workflow is already using the latest stable release of napari, and no update is necessary.
✏️ Learnings added