fix(desktop): resolve package.json loading error in Electron - #2
Merged
Conversation
- Replace new URL() with path.join() to avoid Vite data URL conversion - Fix path to ../../package.json for asar structure - Add json.stringify config to prevent JSON inlining Fixes desktop app failing to start with ERR_INVALID_URL_SCHEME
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Desktop app (v3.3.20) fails to start with error:
Root Cause
packages/core/src/index.tsusesnew URL('../package.json', import.meta.url)which Vite converts to a data URL during bundling, causingreadFileSync(new URL('data:...'))to fail.Solution
new URL()withpath.join(__dirname, '../../package.json')json.stringify: trueto vite config to prevent JSON inliningTesting
Fixes the startup crash in v3.3.20