Installing 1Password CLI version: v

[roryabraham]

We've only seen this happen once as far as I know, so I'm not sure the conditions that cause it. 1Password/install-cli-action can randomly fail with:

Installing 1Password CLI version: v
curl: (22) The requested URL returned error: 404

Maybe just a random network error causes this to fail: https://github.com/1Password/install-cli-action/blob/main/install-cli.sh#L18

Perhaps wrap it with a retry with exponential backoff?

[SimonBarendse]

Hmmm, yeah I think you're on the right track that if that curl comes up empty we have just the v.

I'm a bit surprised though that a network error wouldn't lead the entire script to fail though, even before getting around to printing that "Installing 1Password CLI version: v" line (source), since it sets set -e at the top (source).

According to set -e docs:

Exit immediately if a pipeline, which may consist of a single simple command, a list, or a compound command returns a non-zero status. (source)

Subshells spawned to execute command substitutions inherit the value of the -e option from the parent shell. (source)

[nopcorn]

Just encountered the same thing and can confirm it is caused by a network issue:

Installing 1Password CLI version: v
curl: (28) SSL connection timeout

I ran it on a runner without network connectivity. I'm calling the action without specifying a version, which is causing the version string to be a single v

install-cli-action/install-cli.sh

Line 18 in 36d945b

OP_CLI_VERSION="v$(curl -s $CLI_URL | awk -v RS='<h3>|</h3>' 'NR % 2 == 0 {gsub(/[[:blank:]]+/, ""); gsub(/<span[^>]*>|<\/span>|[\r\n]+/, ""); gsub(/&nbsp;.*$/, ""); if (!'"$1"' && '"$conditional_path"'){print; '"$1"'=1;}}')"

[nopcorn]

I was about to propose a change with --connect-timeout on the curl statement, but I'm not sure overriding user-set system timeout is a good idea. In my case I waited around for 10 minutes before the action failed and at least it provided me with the curl error.

This might be a nofix.

[guidomb]

Hi this started to happen in our CI builds as well out of the sudden. We are using https://www.blacksmith.sh/ as our CI runners

[volodymyrZotov]

This should be tackled by #17

[volodymyrZotov]

Addressed in v2.

Action fetches latest version from https://app-updates.agilebits.com/latest, which has own caching.