Skip to content

fix: set sort_order for newly installed apps to avoid random positioning#12069

Merged
ssongliu merged 1 commit into1Panel-dev:dev-v2from
rowanchen-com:dev-v2
Mar 5, 2026
Merged

fix: set sort_order for newly installed apps to avoid random positioning#12069
ssongliu merged 1 commit into1Panel-dev:dev-v2from
rowanchen-com:dev-v2

Conversation

@rowanchen-com
Copy link
Contributor

What this PR does / why we need it?

Newly installed apps have sort_order defaulting to 0, which causes them to appear at random positions among other apps that also have sort_order = 0. This fix assigns sort_order = max(sort_order) + 1 at install time so new apps always appear at the end of the non-favorite list.

Summary of your change

  • In agent/app/service/app.go, query the current max sort_order of non-favorite apps before creating the install record, and set the new app's sort_order to max + 1.

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 4, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhengkunwang223 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ssongliu ssongliu merged commit 3a0d203 into 1Panel-dev:dev-v2 Mar 5, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants