fix setuptools install error #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes clearbit#34 Credit to @timbedard
| packages=['clearbit', 'clearbit.enrichment'], | ||
| package_data={'clearbit': ['../VERSION']}, | ||
| install_requires=install_requires, | ||
| use_2to3=True, |
There was a problem hiding this comment.
nitpick: I guess this could be the reason why the imports didn't work
Long details:
So the from prospector import Prospector would work perfectly fine in python2.* environment, because imports work differently there and it would actually import the module
The reason it worked within python3 as well, was this line, since it most probably converted the imports or adopted them to py3
Again just wanted to leave it for the info, it will be fixed anyways with #2
igor-yamshchykov
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes clearbit#34
Credit to @timbedard
I decided to create our own fork of clearbit because we have another fix to apply after this as well.