Feature/fix loading of broken classes #12
Merged
+97
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move class reflection logic to a new `get_fully_loadable_class` method to improve clarity and reusability. Added error handling to safely handle non-loadable classes, ensuring smoother execution and fewer runtime errors.
Introduce `BaseClass`, `ChildClass`, and `InvalidChildClass` to the fixtures. Added a test method to validate if these classes are fully loadable, ensuring the module handles valid and invalid class definitions appropriately.
Excluded `InvalidChildClass.php` from analysis to avoid unnecessary errors in test fixtures. This ensures PHPStan runs more cleanly and focuses on relevant code paths.
tlovett1
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR fixes an issue where classes are loaded, even if their parent classes are non-existent. For example, a missing plugin or something that extends
\WP_CLI.How to test the Change
Unit tests are included.
Changelog Entry
Credits
Props @darylldoyle
Checklist: