refactor(proto): Use codegen for proto code generation#1946
Merged
Conversation
sergerad
reviewed
Apr 15, 2026
sergerad
approved these changes
Apr 15, 2026
Collaborator
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Don't think we currently run doc tests, or even if build.rs is considered for them. But otherwise lgtm.
Mirko-von-Leipzig
approved these changes
Apr 16, 2026
This was referenced Apr 16, 2026
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a preparation for GRPC server standardization (see PR #1742) this change moves our
build.rsto use the codegen crate for generatingfile_descriptors.rs.What we're generating now is really trivial, but the changes outlined in PR #1742 will absolutely need something better than concatenating strings.