Port crypto RocksDB budgeted deserialization#1923
Merged
huitseeker merged 6 commits intonextfrom Apr 16, 2026
Merged
Conversation
Source: 0xMiden/crypto commit 3829a5734 (PR #846).
Mirko-von-Leipzig
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports the RocksDB backend change from 0xMiden/crypto#846 “Use budgeted deserialization for untrusted bytes.”
The change updates the migrated RocksDB backend to use
read_from_bytes_with_budgetfor SMT leaves and depth-24 hashes read from RocksDB. The budget is the stored byte length.During validation,
make check-featuresalso found a rocksdb feature-gating gap in store state loading. This PR gates theRocksDbOptionsimport and uses the memory-storage config when therocksdbfeature is off.