Fix compatibility with latest zsh-syntax-highlighting (zle-line-pre-redraw) and use memo= feature #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsh-syntax-highlighting started using zle-line-pre-redraw hook instead
of the legacy "bind all widgets" if 1) zsh has the memo= feature (added
in version 5.9) and 2) add-zle-hook-widget is available.
Now when zsh-history-substring-search is loaded before
zsh-syntax-highlighting, it causes error:
_zsh_highlight_widget_zle-line-pre-redraw: job table full or recursion limit exceeded
See zsh-users/zsh-syntax-highlighting#749
See zsh-users/zsh-syntax-highlighting@810c2dc I'm not sure if it should be used even in our dummy _zsh_highlight or not and, to be honest, I couldn't figure out why is this dummy _zsh_highlight needed at all, so I left it unchanged.
This was referenced Nov 11, 2022
Member
z-sy-h maintainer here. If that function can be removed, please remove it. It's a namespace violation. Thanks. |
|
This fixed an issue for me where |
Member
|
Thanks a lot for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use SPDX snippet tags instead of copy-pasting full license text
Based on spdx/spdx-spec#719
Fix compatibility with latest zsh-syntax-highlighting
zsh-syntax-highlighting started using zle-line-pre-redraw hook instead of the legacy "bind all widgets" if 1) zsh has the memo= feature (added in version 5.9) and 2) add-zle-hook-widget is available.
Now when zsh-history-substring-search is loaded before zsh-syntax-highlighting, it causes error:
See zsh-users/zsh-syntax-highlighting#749
Use new zsh 'memo=' feature to improve interoperability with others
See zsh-users/zsh-syntax-highlighting@810c2dc
I'm not sure if it should be used even in our dummy
_zsh_highlightor not and, to be honest, I couldn't figure out why is this dummy_zsh_highlightneeded at all, so I left it unchanged.