tests: Add edge case tests for setting placeholder regex validation

Author: zendesk-punavwalke

spec/validations/custom_objects_v2/custom_objects_v2_spec.rb

@@ -140,6 +140,56 @@
           ]
         },
         description: 'requirements contain setting placeholder in nested trigger action'
+      },
+      {
+        error: :setting_placeholders_not_allowed_in_cov2_requirements,
+        requirements: {
+          'objects' => [
+            { 'key' => 'object_1', 'title' => '{{setting.value}}', 'title_pluralized' => 'Objects 1',
+              'include_in_list_view' => true }
+          ]
+        },
+        description: 'requirements contain setting placeholder without spaces'
+      },
+      {
+        error: :setting_placeholders_not_allowed_in_cov2_requirements,
+        requirements: {
+          'objects' => [
+            { 'key' => 'object_1', 'title' => '{{  setting.value  }}', 'title_pluralized' => 'Objects 1',
+              'include_in_list_view' => true }
+          ]
+        },
+        description: 'requirements contain setting placeholder with extra whitespace'
+      },
+      {
+        error: :setting_placeholders_not_allowed_in_cov2_requirements,
+        requirements: {
+          'objects' => [
+            { 'key' => 'object_1', 'title' => '{{ setting.my-value }}', 'title_pluralized' => 'Objects 1',
+              'include_in_list_view' => true }
+          ]
+        },
+        description: 'requirements contain setting placeholder with hyphen in property name'
+      },
+      {
+        error: :setting_placeholders_not_allowed_in_cov2_requirements,
+        requirements: {
+          'objects' => [
+            { 'key' => 'object_1', 'title' => '{{ setting.my_value }}', 'title_pluralized' => 'Objects 1',
+              'include_in_list_view' => true }
+          ]
+        },
+        description: 'requirements contain setting placeholder with underscore in property name'
+      },
+      {
+        error: :setting_placeholders_not_allowed_in_cov2_requirements,
+        requirements: {
+          'objects' => [
+            { 'key' => 'object_1', 'title' => '{{ setting.nested.value }}', 'title_pluralized' => 'Objects 1',
+              'include_in_list_view' => true }
+          ]
+        },
+        description: 'requirements contain setting placeholder with dot in property name'
       }
     ].each do |test_case|
       context "when #{test_case[:description]}" do
@@ -198,6 +248,24 @@
           ]
         },
         description: 'requirements contain "setting" without property (should not match)'
+      },
+      {
+        requirements: {
+          'objects' => [
+            { 'key' => 'object_1', 'title' => '{{setting}}', 'title_pluralized' => 'Objects 1',
+              'include_in_list_view' => true }
+          ]
+        },
+        description: 'requirements contain "setting" without property and no spaces (should not match)'
+      },
+      {
+        requirements: {
+          'objects' => [
+            { 'key' => 'object_1', 'title' => '{{ setting. }}', 'title_pluralized' => 'Objects 1',
+              'include_in_list_view' => true }
+          ]
+        },
+        description: 'requirements contain "setting" with dot but no property name (should not match)'
       }
     ].each do |test_case|
       context "when #{test_case[:description]}" do