From dd58e355cc483061e40b9c4ce26a9f34028a321a Mon Sep 17 00:00:00 2001 From: Jeff Hampton Date: Mon, 17 Nov 2025 16:19:50 -0500 Subject: [PATCH] chore: adjust token and commitlint --- .github/workflows/release.yml | 15 +++++++------- commitlint.config.js | 38 ----------------------------------- package.json | 6 +++--- 3 files changed, 10 insertions(+), 49 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index aff69ef..a324005 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -22,14 +22,16 @@ jobs: uses: actions/checkout@v4 with: fetch-depth: 0 # Fetch all history for semantic-release - persist-credentials: false + # Persist credentials for commits during release + # persist-credentials: false + ssh-key: ${{ secrets.RELEASE_SSH_KEY }} - name: 🟢 Setup Node uses: actions/setup-node@v4 with: - node-version: '20' # LTS - cache: 'npm' - registry-url: 'https://registry.npmjs.org' + node-version: "20" # LTS + cache: "npm" + registry-url: "https://registry.npmjs.org" - name: 📦 Install dependencies run: npm ci @@ -52,10 +54,7 @@ jobs: git config user.name "github-actions[bot]" git config user.email "github-actions[bot]@users.noreply.github.com" - # Configure git to use GITHUB_TOKEN for pushing - git remote set-url origin https://x-access-token:${GITHUB_TOKEN}@github.com/${{ github.repository }}.git - - # Run semantic-release + # Run semantic-release (using SSH deploy key from checkout) npx semantic-release - name: 📊 Release Summary diff --git a/commitlint.config.js b/commitlint.config.js index b3fc0bb..983127c 100644 --- a/commitlint.config.js +++ b/commitlint.config.js @@ -1,17 +1,7 @@ -/** - * Commitlint configuration for enforcing conventional commits - * Aligned with platform-sdk-swift configuration - * @see https://commitlint.js.org/ - * @see https://www.conventionalcommits.org/ - */ module.exports = { extends: ["@commitlint/config-conventional"], - rules: { - // Increased body line length to match Swift SDK (300 chars) "body-max-line-length": [2, "always", 300], - - // Type enum - allowed commit types "type-enum": [ 2, "always", @@ -29,33 +19,5 @@ module.exports = { "revert", // Revert previous commit - no version increment ], ], - - // Type must be lowercase - "type-case": [2, "always", "lower-case"], - - // Type is required - "type-empty": [2, "never"], - - // Subject must not be empty - "subject-empty": [2, "never"], - - // Subject must not end with a period - "subject-full-stop": [2, "never", "."], - - // Subject case - sentence case, start case, pascal case, or upper case - "subject-case": [ - 2, - "never", - ["sentence-case", "start-case", "pascal-case", "upper-case"], - ], - - // Header (first line) max length - "header-max-length": [2, "always", 100], - - // Body should have a blank line before it - "body-leading-blank": [1, "always"], - - // Footer should have a blank line before it - "footer-leading-blank": [1, "always"], }, }; diff --git a/package.json b/package.json index 36022ab..35e22ce 100644 --- a/package.json +++ b/package.json @@ -25,13 +25,13 @@ "Bible", "YouVersion" ], - "repository": "https://github.com/youversion/platform-sdk-reactnative", + "repository": "git@github.com:youversion/platform-sdk-reactnative.git", "bugs": { "url": "https://github.com/youversion/platform-sdk-reactnative/issues" }, - "author": "YouVersion (https://github.com/youversion/yvp-react-native-sdk)", + "author": "YouVersion (https://github.com/youversion/platform-sdk-reactnative)", "license": "Apache-2.0", - "homepage": "https://github.com/youversion/yvp-react-native-sdk#readme", + "homepage": "https://github.com/youversion/platform-sdk-reactnative#readme", "jest": { "preset": "expo-module-scripts" },