feat: Implement SignInWithYouVersionButton for Kotlin#26
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
69628ab to
92ace35
Compare
There was a problem hiding this comment.
Pull request overview
This PR implements the Android/Kotlin version of the SignInWithYouVersionButton component for the React Native SDK. The implementation wraps the native Kotlin SDK's sign-in button and exposes it through the React Native bridge using Expo modules.
Key changes:
- Adds Android module registration in expo-module.config.json
- Creates RNSignInWithYouVersionButtonModule for Expo module definition
- Implements YVPSignInWithYouVersionButton view with full customization support (mode, shape, stroke, color scheme)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| expo-module.config.json | Registers the new SignInWithYouVersionButton module for Android |
| android/src/main/java/com/youversion/reactnativesdk/RNSignInWithYouVersionButtonModule.kt | Defines the Expo module and event handlers for the sign-in button |
| android/src/main/java/com/youversion/reactnativesdk/views/YVPSignInWithYouVersionButton.kt | Implements the Compose-based view wrapper with prop handling and theme customization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
92ace35 to
07132b5
Compare
|
@codex please review. |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
## 0.8.0 (2026-01-16) * chore: Depend on most recent Swift SDK version and update breaking changes (#27) ([a042211](a042211)), closes [#27](#27) * chore(ci): Disable NPM tokens in release workflow (#28) ([c63c21a](c63c21a)), closes [#28](#28) * chore(ci): update semantic-release to support OIDC workflow (#29) ([de337dc](de337dc)), closes [#29](#29) * chore(ci): YPE-1050 Modify release.yml for permissions and Node.js version ([2c86c6f](2c86c6f)) * Add NODE_AUTH_TOKEN to release workflow ([2bdc89c](2bdc89c)) * Add provenance option to npm release configuration ([d746acf](d746acf)) * Enable NPM_CONFIG_PROVENANCE in release workflow ([e027853](e027853)) * Update Node.js version and add NPM upgrade step ([ee94aa2](ee94aa2)) * feat: add support for `configure` in Kotlin (#16) ([d9bca2d](d9bca2d)), closes [#16](#16) * feat: implement `setApiHost` and `getAccessToken` in Kotlin (#17) ([a4ee43c](a4ee43c)), closes [#17](#17) * feat: Implement `SignInWithYouVersionButton` for Kotlin (#26) ([5072471](5072471)), closes [#26](#26) * feat: Implement API utils for Kotlin/Android (#25) ([9a88926](9a88926)), closes [#25](#25) * feat: implement votd API endpoint for Kotlin (#19) ([59e6874](59e6874)), closes [#19](#19) * docs: add AI agent code review guidelines (#23) ([8218cec](8218cec)), closes [#23](#23)
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR wraps the Kotlin SDK and exposes the sign in button (and all of its customizations) for the RN SDK.
Type of Change
feat:New feature (non-breaking change which adds functionality)fix:Bug fix (non-breaking change which fixes an issue)docs:Documentation updaterefactor:Code refactoring (no functional changes)perf:Performance improvementtest:Test additions or updatesbuild:Build system or dependency changesci:CI configuration changeschore:Other changes (maintenance, etc.)Checklist