feat: implement votd API endpoint for Kotlin#19
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements the Verse of the Day (VOTD) API endpoint for the Android/Kotlin side of the React Native SDK, providing feature parity with the existing iOS implementation.
- Adds
YVPVotdApiobject with a suspend function to fetch verse of the day data from the platform core API - Introduces
YouVersionVerseOfTheDayRecorddata class to properly map the response to Expo modules' Record type - Exposes the
verseOfTheDayasync function in the React Native module using Expo's Coroutine support
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| android/src/main/java/com/youversion/reactnativesdk/api/YVPVotdApi.kt | Implements the API layer that calls the platform core VOTD API and returns the mapped record |
| android/src/main/java/com/youversion/reactnativesdk/api/YVPRecords.kt | Defines the YouVersionVerseOfTheDayRecord data class that maps the platform model to an Expo-compatible Record |
| android/src/main/java/com/youversion/reactnativesdk/RNYouVersionPlatformModule.kt | Registers the verseOfTheDay async function as a coroutine-based module function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dsrees
reviewed
Nov 19, 2025
Collaborator
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
dsrees
approved these changes
Nov 21, 2025
dsrees
left a comment
Collaborator
There was a problem hiding this comment.
I have no other comments on this PR but I'm also not as involved in the RN SDK so I'll defer to others for a final review
mic-mart
approved these changes
Nov 24, 2025
mic-mart
left a comment
Collaborator
There was a problem hiding this comment.
I made some comments, but no definite blockers.
097b5af to
7fd5e56
Compare
3f10fb8 to
3c763ee
Compare
jhampton
pushed a commit
that referenced
this pull request
Jan 16, 2026
## 0.8.0 (2026-01-16) * chore: Depend on most recent Swift SDK version and update breaking changes (#27) ([a042211](a042211)), closes [#27](#27) * chore(ci): Disable NPM tokens in release workflow (#28) ([c63c21a](c63c21a)), closes [#28](#28) * chore(ci): update semantic-release to support OIDC workflow (#29) ([de337dc](de337dc)), closes [#29](#29) * chore(ci): YPE-1050 Modify release.yml for permissions and Node.js version ([2c86c6f](2c86c6f)) * Add NODE_AUTH_TOKEN to release workflow ([2bdc89c](2bdc89c)) * Add provenance option to npm release configuration ([d746acf](d746acf)) * Enable NPM_CONFIG_PROVENANCE in release workflow ([e027853](e027853)) * Update Node.js version and add NPM upgrade step ([ee94aa2](ee94aa2)) * feat: add support for `configure` in Kotlin (#16) ([d9bca2d](d9bca2d)), closes [#16](#16) * feat: implement `setApiHost` and `getAccessToken` in Kotlin (#17) ([a4ee43c](a4ee43c)), closes [#17](#17) * feat: Implement `SignInWithYouVersionButton` for Kotlin (#26) ([5072471](5072471)), closes [#26](#26) * feat: Implement API utils for Kotlin/Android (#25) ([9a88926](9a88926)), closes [#25](#25) * feat: implement votd API endpoint for Kotlin (#19) ([59e6874](59e6874)), closes [#19](#19) * docs: add AI agent code review guidelines (#23) ([8218cec](8218cec)), closes [#23](#23)
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
feat:New feature (non-breaking change which adds functionality)fix:Bug fix (non-breaking change which fixes an issue)docs:Documentation updaterefactor:Code refactoring (no functional changes)perf:Performance improvementtest:Test additions or updatesbuild:Build system or dependency changesci:CI configuration changeschore:Other changes (maintenance, etc.)Breaking Changes
Breaking Change Details:
Migration Guide:
Checklist
Conventional Commits
✅ All commits in this PR follow conventional commit format:
Example commit messages:
feat(api): add Bible verse lookup methodfix(auth): resolve token refresh race conditiondocs: update installation instructionsFor breaking changes:
feat(api)!: redesign Bible content APISee CONTRIBUTING.md for detailed guidelines.
Related Issues
Closes https://lifechurch.atlassian.net/browse/YPE-757
Relates to #
Additional Context
Reviewer Notes