feat: implement setApiHost and getAccessToken in Kotlin#17
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements two new platform functions (setApiHost and getAccessToken) for the Kotlin/Android portion of the React Native SDK, completing the feature parity with the iOS implementation.
- Adds
setApiHostfunction to allow configuration of the API host endpoint - Adds
getAccessTokenfunction to retrieve the current access token - Both functions delegate to
YouVersionPlatformConfigurationfrom the underlying Kotlin SDK
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
mic-mart
left a comment
There was a problem hiding this comment.
Looks good.
On a broader level (affecting Swift, Kotlin, and RN)...
- Should we validate the
apiHostwhen callingsetApiHostto ensure it's a valid URL? - Should we validate it against a list of approved hosts and not be open-ended?
097b5af to
7fd5e56
Compare
## 0.8.0 (2026-01-16) * chore: Depend on most recent Swift SDK version and update breaking changes (#27) ([a042211](a042211)), closes [#27](#27) * chore(ci): Disable NPM tokens in release workflow (#28) ([c63c21a](c63c21a)), closes [#28](#28) * chore(ci): update semantic-release to support OIDC workflow (#29) ([de337dc](de337dc)), closes [#29](#29) * chore(ci): YPE-1050 Modify release.yml for permissions and Node.js version ([2c86c6f](2c86c6f)) * Add NODE_AUTH_TOKEN to release workflow ([2bdc89c](2bdc89c)) * Add provenance option to npm release configuration ([d746acf](d746acf)) * Enable NPM_CONFIG_PROVENANCE in release workflow ([e027853](e027853)) * Update Node.js version and add NPM upgrade step ([ee94aa2](ee94aa2)) * feat: add support for `configure` in Kotlin (#16) ([d9bca2d](d9bca2d)), closes [#16](#16) * feat: implement `setApiHost` and `getAccessToken` in Kotlin (#17) ([a4ee43c](a4ee43c)), closes [#17](#17) * feat: Implement `SignInWithYouVersionButton` for Kotlin (#26) ([5072471](5072471)), closes [#26](#26) * feat: Implement API utils for Kotlin/Android (#25) ([9a88926](9a88926)), closes [#25](#25) * feat: implement votd API endpoint for Kotlin (#19) ([59e6874](59e6874)), closes [#19](#19) * docs: add AI agent code review guidelines (#23) ([8218cec](8218cec)), closes [#23](#23)
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR implements the other 2 platform-y like functions:
getAccessTokenandsetApiHostfor the Kotlin portion of this SDK.Type of Change
feat:New feature (non-breaking change which adds functionality)fix:Bug fix (non-breaking change which fixes an issue)docs:Documentation updaterefactor:Code refactoring (no functional changes)perf:Performance improvementtest:Test additions or updatesbuild:Build system or dependency changesci:CI configuration changeschore:Other changes (maintenance, etc.)Breaking Changes
Breaking Change Details:
Migration Guide:
Checklist
Conventional Commits
✅ All commits in this PR follow conventional commit format:
Example commit messages:
feat(api): add Bible verse lookup methodfix(auth): resolve token refresh race conditiondocs: update installation instructionsFor breaking changes:
feat(api)!: redesign Bible content APISee CONTRIBUTING.md for detailed guidelines.
Related Issues
Closes #
Relates to #
Additional Context
Reviewer Notes
The Kotlin SDK portion for
setApiHostis still in review here.