Skip to content

Conversation

@dahbka-lis
Copy link
Member

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copilot AI review requested due to automatic review settings December 4, 2025 13:46
@dahbka-lis dahbka-lis requested review from a team as code owners December 4, 2025 13:46
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

🟢 2025-12-04 13:47:48 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

2025-12-04 13:47:59 UTC Pre-commit check linux-x86_64-release-asan for 8712ce0 has started.
2025-12-04 13:48:14 UTC Artifacts will be uploaded here
2025-12-04 13:50:18 UTC ya make is running...
🟡 2025-12-04 14:55:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12416 12328 0 67 10 11

🟢 2025-12-04 14:56:07 UTC Build successful.
🟢 2025-12-04 14:56:37 UTC ydbd size 3.8 GiB changed* by -112 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4089911 merge: 8712ce0 diff diff %
ydbd size 4 123 223 512 Bytes 4 123 223 400 Bytes -112 Bytes -0.000%
ydbd stripped size 1 531 161 144 Bytes 1 531 161 080 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ydbot
Copy link
Collaborator

ydbot commented Dec 4, 2025

Run Extra Tests

Run additional tests for this PR. You can customize:

  • Test Size: small, medium, large (default: all)
  • Test Targets: any directory path (default: ydb/)
  • Sanitizers: ASAN, MSAN, TSAN
  • Coredumps: enable for debugging (default: off)
  • Additional args: custom ya make arguments

▶  Run tests

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

2025-12-04 13:49:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8712ce0 has started.
2025-12-04 13:49:31 UTC Artifacts will be uploaded here
2025-12-04 13:51:39 UTC ya make is running...
🟡 2025-12-04 15:21:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40084 37222 0 2 2842 18

2025-12-04 15:21:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-12-04 15:35:01 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
36 (only retried tests) 22 0 0 0 14

🟢 2025-12-04 15:35:07 UTC Build successful.
🟢 2025-12-04 15:35:30 UTC ydbd size 2.3 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4089911 merge: 8712ce0 diff diff %
ydbd size 2 463 956 400 Bytes 2 463 956 400 Bytes 0 Bytes 0.000%
ydbd stripped size 524 487 328 Bytes 524 487 328 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables support for extended date types (Date32, Datetime64, Timestamp64, Interval64) in DQ Merge Connections by moving them from the unsupported to supported section in the type checking function.

  • Moves four extended date type cases from unsupported to supported in IsTypeSupportedInMergeCn

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Run-tests started

  • Build Preset: relwithdebinfo
  • Test Size: small,medium,large
  • Test Targets: ydb/
  • Collect Coredumps: true
  • Commit: cd8e4e8
  • Workflow run: link

2025-12-04 14:58:47 UTC Artifacts will be uploaded here
2025-12-04 14:59:58 UTC ya make is running...

@dahbka-lis dahbka-lis linked an issue Dec 4, 2025 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Dec 6, 2025

2025-12-06 12:24:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 93ddb55 has started.
2025-12-06 12:24:54 UTC Artifacts will be uploaded here
2025-12-06 12:27:09 UTC ya make is running...
🟡 2025-12-06 14:03:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40160 37229 0 4 2906 21

2025-12-06 14:04:00 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-12-06 14:15:51 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
48 (only retried tests) 36 0 0 0 12

🟢 2025-12-06 14:15:59 UTC Build successful.
🟢 2025-12-06 14:16:20 UTC ydbd size 2.3 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 25029c1 merge: 93ddb55 diff diff %
ydbd size 2 466 169 640 Bytes 2 466 169 640 Bytes 0 Bytes 0.000%
ydbd stripped size 524 846 208 Bytes 524 846 208 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

2025-12-06 12:24:37 UTC Pre-commit check linux-x86_64-release-asan for 93ddb55 has started.
2025-12-06 12:24:55 UTC Artifacts will be uploaded here
2025-12-06 12:27:04 UTC ya make is running...
🟡 2025-12-06 13:33:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12427 12348 0 64 8 7

🟢 2025-12-06 13:33:45 UTC Build successful.
🟢 2025-12-06 13:34:15 UTC ydbd size 3.8 GiB changed* by -112 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 25029c1 merge: 93ddb55 diff diff %
ydbd size 4 127 824 880 Bytes 4 127 824 768 Bytes -112 Bytes -0.000%
ydbd stripped size 1 532 696 344 Bytes 1 532 696 280 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dahbka-lis dahbka-lis merged commit 34c1681 into ydb-platform:main Dec 6, 2025
9 checks passed
@ydbot
Copy link
Collaborator

ydbot commented Dec 6, 2025

Backport

To backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.

Branch Run
stable-25-2, stable-25-2-1, stable-25-3, stable-25-3-1 ▶  Backport
stable-25-3, stable-25-3-1 ▶  Backport
stable-25-3 ▶  Backport

▶  Backport manual

@ydbot
Copy link
Collaborator

ydbot commented Dec 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Date32, Datetime64, Timestamp64, Interval64 to supported for DqMergeCh Bug: ORDER BY does not work for Date32 columns

3 participants