Activity Tab - Existing funnel tweaks #5583
Open
+31
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ bump schema versions to match https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-secondary/-/merge_requests/101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T406873 + some of https://phabricator.wikimedia.org/T411544
Notes
This PR fixes missing instrumentation events for https://phabricator.wikimedia.org/T406873. It also bumps the version for
ios_login_actionandios_navigation_eventsto allow our newactivity_tabenums to go through to the backend.Dependency: The MR at https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-secondary/-/merge_requests/101 must be merged in order for this to go through.
Test Steps