-
-
Notifications
You must be signed in to change notification settings - Fork 828
Add Debug Xcode Configuration #5417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @bo2themax ! Thanks!! |
tonisevener
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bo2themax! Thanks for working on this one and for your patience with our review. I found a couple of minor unused vars. I also notice when I run .scripts/setup from a freshly-cloned state, I see this error:
scripts/setup_bundle_id: line 15: scripts/../Configurations/OpenSourceDebug.xcconfig: No such file or directory
So maybe we should have the script create the Configurations directory in root if it doesn't already exist.
bf9e898 to
9d9ab41
Compare
Thank you @tonisevener! I haven't been able to install older virtual machines to test Xcode 15+, now it's working in a freshly cloned state with Xcode 16+. Better to squash this pr if it's going into main. |
This is the default one, which is basically the same one baked into the xcodeproj.
Check if each formula is installed, if not install it, do not upgrade against the user's wishes
Developers may also be using distributed provision files
04e7850 to
2a2dfdd
Compare
Notes
brew_installscript to avoid unwanted upgrades for developers who are strict about tool versions.ci_pre_xcodebuildto set up the default configuration, which should be the same as the previous project settings.Test Steps
scripts/setupScreenshots/Videos