LazyLoad: add new test for changing base URL #20683
Conversation
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
5234bae to
5855f8e
Compare
|
@annevk do you think the tests are correct? Currently failing in Chrome and we are not sure if Chrome is wrong or the tests :) |
annevk
left a comment
There was a problem hiding this comment.
From a quick skim this basically looks correct to me, I do have some suggestions/questions though.
| }); | ||
|
|
||
| async_test(function(t) { | ||
| below_viewport_img.promise.then( |
There was a problem hiding this comment.
If you're dealing with a promise, using promise_test and async functions might be nicer.
There was a problem hiding this comment.
Not very familiar with them, would prefer to stick to current approach.
5855f8e to
8ba6efc
Compare
annevk
left a comment
There was a problem hiding this comment.
Sure, I recommend finding some time to learn them though as both promise_test (guarantees sequential execution compared to async_test, and looks nice if you're dealing with promises anyway) and async functions (look nice) are pretty great.
Ok will look into it :) Thanks for the review. |
8ba6efc to
154737d
Compare
domfarolino
left a comment
There was a problem hiding this comment.
Sorry, while finishing this review I realized I should have probably written this up in https://crrev.com/c/1954508. Can you address these over there?
6c5ef0b to
506af24
Compare
Add new tests for changing base URL, the test original-base-url-applied-tentative.html changed the document URL, which only implicitly changed the document's base URL. These tests explicitly change the document's base URL via the <base> element. Bug: 984983 Change-Id: I5ab855aaecc8bd12502eb32a3b1d26ae5ced31a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954508 Reviewed-by: Dominic Farolino <[email protected]> Commit-Queue: Rob Buis <[email protected]> Cr-Commit-Position: refs/heads/master@{#724964}
506af24 to
96828fe
Compare
domfarolino
left a comment
There was a problem hiding this comment.
Approving since I've approved on crrev and the CL has landed
Follow-up: #5236. Tests: * web-platform-tests/wpt#14914 * web-platform-tests/wpt#17985 * web-platform-tests/wpt#18087 * web-platform-tests/wpt#20634 * web-platform-tests/wpt#20747 * web-platform-tests/wpt#20683 * web-platform-tests/wpt#20774 * web-platform-tests/wpt#20680 * Some as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1542784 Closes #2806. Closes #5250. Co-authored-by: Dominic Farolino <[email protected]> Co-authored-by: Anne van Kesteren <[email protected]>
Add new tests for changing base URL, the test
original-base-url-applied-tentative.html changed the document URL, which
only implicitly changed the document's base URL. These tests explicitly
change the document's base URL via the <base> element.
Bug: 984983
Change-Id: I5ab855aaecc8bd12502eb32a3b1d26ae5ced31a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954508
Reviewed-by: Dominic Farolino <[email protected]>
Commit-Queue: Rob Buis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#724964}