Skip to content

Module Manifest - Fix LicenseURI 404 #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vexx32 merged 1 commit into from
Nov 11, 2019
Merged

Module Manifest - Fix LicenseURI 404 #324

vexx32 merged 1 commit into from
Nov 11, 2019

Conversation

@weq
Copy link
Contributor

@weq weq commented Nov 11, 2019 •
edited by vexx32
Loading

PR Summary

Fixed the LicenseURI in the manifest. It was linking to a URL that was dead after removal of dev branch most likely.

Context

Changes

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
      Do you really_ want a test that checks the psd and tries all URLs for a 200 status?
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added the Category-Module Pertaining to the module's functionality itself. label Nov 11, 2019
vexx32
vexx32 approved these changes Nov 11, 2019
View reviewed changes
Copy link
Owner

@vexx32 vexx32 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a whole lot of point testing these. Maybe I'll invest in some link checkers in future but that's a very low priority lol.

Thanks for taking care of it for me! 💖

@vexx32 vexx32 changed the title LicenseURI = 404 Module Manifest - Fix LicenseURI 404 Nov 11, 2019
@vexx32 vexx32 merged commit 2269c5d into vexx32:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vexx32 vexx32 vexx32 approved these changes

@steviecoaster steviecoaster Awaiting requested review from steviecoaster

Assignees

No one assigned

Labels

Category-Module Pertaining to the module's functionality itself.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@weq @vexx32