-
Notifications
You must be signed in to change notification settings - Fork 190
Adding Accept-Language-header to interceptor #1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Romina Suarez <[email protected]>
|
Lets get this into the release since David will need it, and make sure Walter tests it? @Angamanga |
|
@rowasc Yep, plus the backend-changes, right? |
|
yep sending both |
|
@Obadha2 This will be included in the release too, could you test in Steve Buscemi? 🎉 🙏 |
|
just a heads up : I've had trouble testing this with firefox on my localhost , the header was not changed after switching languages. will give it another try tomorrow with other browsers / steve-buscemi |
|
mmm ok nevermind about my previous comment. I must have been too tired. |
|
@Angamanga while running smoke tests, i noticed the following: |
I think this more or less matches the expected behavior I read from the code: if the user account has a language preference, that should always take precedence over the language chosen in "General settings". (I'm assuming the "old account" had some language preference saved in the database) |
|
@tuxpiper @Obadha2 Yep, that is the expected behaviour right now at least, but it is confusing. There is a wip pr that deals with it, but its abandoned (by me) right now. Plan to take up work on it. |
This pull request makes the following changes:
-Adding Accept-Language header to send the user-selected language to Auth-interceptor
Testing checklist:
Switch language to Spanish (Spanish is the only translations we have right now)
Try signing up with an email address already known
The Error-message should be in Spanish
GO to settings-categories
Add a category with the same name as one that already exists
The error message (or part of it, its not all translated yet) should be in Spanish
Any other error-messages showing up as the error-toast-bar should be translated (it there are corresponding translations in the backend)
I certify that I ran my checklist
Fixes ushahidi/platform# .
Ping @ushahidi/platform