Skip to content

Conversation

@Angamanga
Copy link
Collaborator

@Angamanga Angamanga commented Jan 22, 2020

This pull request makes the following changes:
-Adding Accept-Language header to send the user-selected language to Auth-interceptor

Testing checklist:

  • Switch language to Spanish (Spanish is the only translations we have right now)

  • Try signing up with an email address already known

  • The Error-message should be in Spanish

  • GO to settings-categories

  • Add a category with the same name as one that already exists

  • The error message (or part of it, its not all translated yet) should be in Spanish

  • Any other error-messages showing up as the error-toast-bar should be translated (it there are corresponding translations in the backend)

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

@Angamanga Angamanga requested a review from rowasc January 22, 2020 15:17
@rowasc
Copy link
Contributor

rowasc commented Jan 22, 2020

Lets get this into the release since David will need it, and make sure Walter tests it? @Angamanga
this should be the only extra change going into it except for the bugfix you are doing for filters , sorry 😬 !

@Angamanga
Copy link
Collaborator Author

@rowasc Yep, plus the backend-changes, right?

@rowasc
Copy link
Contributor

rowasc commented Jan 22, 2020

yep sending both

@rowasc rowasc merged commit a6eda4b into develop Jan 22, 2020
@Angamanga
Copy link
Collaborator Author

@Obadha2 This will be included in the release too, could you test in Steve Buscemi? 🎉 🙏

@tuxpiper
Copy link
Member

tuxpiper commented Mar 4, 2020

just a heads up : I've had trouble testing this with firefox on my localhost , the header was not changed after switching languages.

will give it another try tomorrow with other browsers / steve-buscemi

@tuxpiper
Copy link
Member

tuxpiper commented Mar 5, 2020

mmm ok nevermind about my previous comment. I must have been too tired.

@theobadha
Copy link
Contributor

@Angamanga while running smoke tests, i noticed the following:
From an old account, when I change language from General settings, language changes don't come into effect when I click Save, I have to log out of the account. When logged out, then the new language changes are seen.
However, I created a new account. When I change language from General Settings in a newly created account, when I click Save, language changes are seen immediately.

@tuxpiper
Copy link
Member

@Angamanga while running smoke tests, i noticed the following:
From an old account, when I change language from General settings, language changes don't come into effect when I click Save, I have to log out of the account. When logged out, then the new language changes are seen.
However, I created a new account. When I change language from General Settings in a newly created account, when I click Save, language changes are seen immediately.

I think this more or less matches the expected behavior I read from the code: if the user account has a language preference, that should always take precedence over the language chosen in "General settings". (I'm assuming the "old account" had some language preference saved in the database)

@Angamanga
Copy link
Collaborator Author

@tuxpiper @Obadha2 Yep, that is the expected behaviour right now at least, but it is confusing. There is a wip pr that deals with it, but its abandoned (by me) right now. Plan to take up work on it.

@tuxpiper tuxpiper deleted the add-lang-headers branch March 24, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants