Allow user to delete their own contact #769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ifycode
requested changes
Feb 13, 2024
| canDeleteContact(contact: ContactsInterface) { | ||
| return contact.allowed_privileges?.includes('delete'); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
The remove button & modal shows up for non-admin user @ushahidlee 👍🏼
But the response from the contacts API endpoint is a 403-forbidden for such user - images below.
Question: Is there a separate fix for this already on the backend that gives such users access and that one can test with yet?
Contributor
Author
There was a problem hiding this comment.
Yeah there is a separate PR for backend.
Ifycode
approved these changes
Feb 14, 2024
| canDeleteContact(contact: ContactsInterface) { | ||
| return contact.allowed_privileges?.includes('delete'); | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the visibility of the delete button, to allow a user to delete their own contact.