Skip to content

Conversation

@Angamanga
Copy link
Contributor

@Angamanga Angamanga commented Jan 5, 2024

This PR:

  • Removes the preselected datasource in the dropdown when adding a new datasource
  • Displays the spinner when waiting for the data

To test:

  • Go to settings->data-sources
  • Click on "Add source"
  • The spinner appears for a while when fetching data (not entirely sure why it takes so long? Or if it just on my side?)
  • The dropdown appears, with no preselection

When testing, make sure that:

  • The edit-form behaves as expected. It is using the same code as the add-source functionality.

Issue: https://linear.app/ushahidi/issue/USH-1024/on-opening-add-data-source-page-dont-preselect-a-data-source-fe

@Angamanga Angamanga changed the title 937 data source selection USH-1024 Removing pre-selection when adding a new data-source Jan 23, 2024
@linear
Copy link

linear bot commented Jan 23, 2024

@Angamanga Angamanga marked this pull request as ready for review January 23, 2024 08:45
Copy link
Contributor

@ushahidlee ushahidlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Angamanga Angamanga merged commit 8920ee1 into development Jan 24, 2024
shakirandagire pushed a commit that referenced this pull request Jan 30, 2024
* Removing preselection of data-source in settings

* Displaying spinner in the right moment and place

---------

Co-authored-by: Anna Iosif <[email protected]>
theobadha added a commit that referenced this pull request Feb 6, 2024
* Verify that the user details show correctly after logging in

* Rectify the failing tests

* Rectify the failing tests

* Fix the failing tests

* Fix the failing tests

* Add locators to check if the user details exist after login

* Fix the login locators

* Add admin name to .env file

* Add admin name to .env file

* 1070 hidden field indicator (#747)

* Adding https-icon to svg-library

* Adding indicator to private fields

* USH-1024 Removing pre-selection when adding a new data-source (#736)

* Removing preselection of data-source in settings

* Displaying spinner in the right moment and place

---------

Co-authored-by: Anna Iosif <[email protected]>

* Checking for no Tweet (#739)

* Add admin name to test and ship file

* Add function to admin

* change browser size for name and email to be visible

---------

Co-authored-by: Shakira <[email protected]>
Co-authored-by: Anna Iosif <[email protected]>
Co-authored-by: Anna Iosif <[email protected]>
Co-authored-by: AmTryingMyBest <[email protected]>
Co-authored-by: Walter <[email protected]>
@Angamanga Angamanga deleted the 937-data-source-selection branch May 8, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants