Show Download all as ZIP button only when all conditions are met (DSpace#606)

* Show download all in zip button only when all conditions are met

* Updated test because of new updates

Author: milanmajchrak

src/app/item-page/clarin-files-section/clarin-files-section.component.html

@@ -13,10 +13,14 @@ <h6><i class="fa fa-paperclip">&nbsp;</i>{{'item.page.files.head' | translate}}<
         <pre class="command-pre">{{ command }}</pre>
     </div>
     <span>
-      <a *ngIf="canDownloadAllFiles" class="btn btn-download" id="download-all-button" (click)="downloadFiles()"
+      <a *ngIf="
+      (totalFileSizes | async) > (downloadZipMinFileSize | async) &&
+      (totalFileSizes | async) < (downloadZipMaxFileSize | async) &&
+      (listOfFiles | async).length >= (downloadZipMinFileCount | async)"
+         class="btn btn-download" id="download-all-button" (click)="downloadFiles()"
          style="visibility: visible">
         <i style="display: block" class="fa fa-download fa-3x">&nbsp;</i>
-        {{'item.page.download.button.all.files.zip' | translate}} ({{ totalFileSizes | dsFileSize }})
+        {{'item.page.download.button.all.files.zip' | translate}} ({{ (totalFileSizes | async) | dsFileSize }})
       </a>
     </span>
   </div>

src/app/item-page/clarin-files-section/clarin-files-section.component.spec.ts

@@ -9,7 +9,11 @@ import { TranslateModule } from '@ngx-translate/core';
 import { MetadataBitstream } from '../../core/metadata/metadata-bitstream.model';
 import { ResourceType } from '../../core/shared/resource-type';
 import { HALLink } from '../../core/shared/hal-link.model';
-import { BehaviorSubject , of} from 'rxjs';
+import { BehaviorSubject , of } from 'rxjs';
+import { ConfigurationDataService } from '../../core/data/configuration-data.service';
+import { Item } from '../../core/shared/item.model';
+import { createSuccessfulRemoteDataObject$ } from '../../shared/remote-data.utils';
+import { createPaginatedList } from '../../shared/testing/utils.test';
 
 describe('ClarinFilesSectionComponent', () => {
   let component: ClarinFilesSectionComponent;
@@ -38,6 +42,22 @@ describe('ClarinFilesSectionComponent', () => {
   const metadataBitstreams: MetadataBitstream[] = [metadatabitstream];
   const bitstreamStream = new BehaviorSubject(metadataBitstreams);
 
+  const mockItem: Item = Object.assign(new Item(), {
+    bundles: createSuccessfulRemoteDataObject$(createPaginatedList([])),
+    metadata: {
+      'local.files.size': [
+        {
+          language: 'en_US',
+          value: '123'
+        }
+      ]
+    }
+  });
+
+  const configurationServiceSpy = jasmine.createSpyObj('configurationService', {
+    findByPropertyName: of('123456'),
+  });
+
   beforeEach(async () => {
     mockRegistryService = jasmine.createSpyObj('RegistryService', {
       'getMetadataBitstream': of(bitstreamStream)
@@ -53,13 +73,15 @@ describe('ClarinFilesSectionComponent', () => {
       providers: [
         { provide: RegistryService, useValue: mockRegistryService },
         { provide: Router, useValue: new RouterMock() },
-        { provide: HALEndpointService, useValue: halService }
+        { provide: HALEndpointService, useValue: halService },
+        { provide: ConfigurationDataService, useValue: configurationServiceSpy },
       ],
     })
     .compileComponents();
 
     fixture = TestBed.createComponent(ClarinFilesSectionComponent);
     component = fixture.componentInstance;
+    component.item = mockItem;
     fixture.detectChanges();
   });
 

src/app/item-page/clarin-files-section/clarin-files-section.component.ts

@@ -1,11 +1,13 @@
 import { Component, Input, OnInit } from '@angular/core';
 import { Item } from '../../core/shared/item.model';
-import { getAllSucceededRemoteListPayload } from '../../core/shared/operators';
+import { getAllSucceededRemoteListPayload, getFirstSucceededRemoteDataPayload } from '../../core/shared/operators';
 import { getItemPageRoute } from '../item-page-routing-paths';
 import { MetadataBitstream } from '../../core/metadata/metadata-bitstream.model';
 import { RegistryService } from '../../core/registry/registry.service';
 import { Router } from '@angular/router';
 import { HALEndpointService } from '../../core/shared/hal-endpoint.service';
+import { ConfigurationDataService } from '../../core/data/configuration-data.service';
+import { BehaviorSubject } from 'rxjs';
 
 @Component({
   selector: 'ds-clarin-files-section',
@@ -44,28 +46,48 @@ export class ClarinFilesSectionComponent implements OnInit {
   /**
    * total size of list of files uploaded by users to this item
    */
-  totalFileSizes: number;
+  totalFileSizes: BehaviorSubject<number> = new BehaviorSubject<number>(-1);
 
   /**
    * list of files uploaded by users to this item
    */
-  listOfFiles: MetadataBitstream[];
+  listOfFiles: BehaviorSubject<MetadataBitstream[]> = new BehaviorSubject<MetadataBitstream[]>([]);
+
+  /**
+   * min file size to show `Download all ZIP` button, this value is loaded from the configuration property
+   * `download.all.alert.min.file.size`
+   */
+  downloadZipMinFileSize: BehaviorSubject<number> = new BehaviorSubject<number>(-1);
+
+  /**
+   * max file size to show `Download all ZIP` button, this value is loaded from the configuration property
+   * `download.all.limit.max.file.size`
+   */
+  downloadZipMaxFileSize: BehaviorSubject<number> = new BehaviorSubject<number>(-1);
+
+  /**
+   * min count of files to show `Download all ZIP` button, this value is loaded from the configuration property
+   * `download.all.limit.min.file.count`
+   */
+  downloadZipMinFileCount: BehaviorSubject<number> = new BehaviorSubject<number>(-1);
 
 
   constructor(protected registryService: RegistryService,
               protected router: Router,
-              protected halService: HALEndpointService) {
+              protected halService: HALEndpointService,
+              protected configurationService: ConfigurationDataService) {
   }
 
   ngOnInit(): void {
     this.registryService
       .getMetadataBitstream(this.itemHandle, 'ORIGINAL,TEXT,THUMBNAIL')
       .pipe(getAllSucceededRemoteListPayload())
       .subscribe((data: MetadataBitstream[]) => {
-        this.listOfFiles = data;
+        this.listOfFiles.next(data);
         this.generateCurlCommand();
-        this.sumFileSizes();
       });
+    this.totalFileSizes.next(Number(this.item.firstMetadataValue('local.files.size')));
+    this.loadDownloadZipConfigProperties();
   }
 
   setCommandline() {
@@ -77,12 +99,7 @@ export class ClarinFilesSectionComponent implements OnInit {
   }
 
   generateCurlCommand() {
-    const fileNames = this.listOfFiles.map((file: MetadataBitstream) => {
-      // Show `Download All Files` only if there are more files.
-      if (this.listOfFiles.length > 1) {
-        this.canDownloadAllFiles = true;
-      }
-
+    const fileNames = this.listOfFiles.value.map((file: MetadataBitstream) => {
       if (file.canPreview) {
         this.canShowCurlDownload = true;
       }
@@ -95,11 +112,29 @@ export class ClarinFilesSectionComponent implements OnInit {
     }/{${fileNames.join(',')}}`;
   }
 
-  sumFileSizes() {
-    let totalBytes = 0;
-    this.listOfFiles.forEach((file) => {
-      totalBytes += file.fileSize;
-    });
-    this.totalFileSizes = totalBytes;
+  loadDownloadZipConfigProperties() {
+    this.configurationService.findByPropertyName('download.all.limit.min.file.count')
+      .pipe(
+        getFirstSucceededRemoteDataPayload()
+      )
+      .subscribe((config) => {
+        this.downloadZipMinFileCount.next(Number(config.values[0]));
+      });
+
+    this.configurationService.findByPropertyName('download.all.limit.max.file.size')
+      .pipe(
+        getFirstSucceededRemoteDataPayload()
+      )
+      .subscribe((config) => {
+        this.downloadZipMaxFileSize.next(Number(config.values[0]));
+      });
+
+    this.configurationService.findByPropertyName('download.all.alert.min.file.size')
+      .pipe(
+        getFirstSucceededRemoteDataPayload()
+      )
+      .subscribe((config) => {
+        this.downloadZipMinFileSize.next(Number(config.values[0]));
+      });
   }
 }