Skip to content

fix(polkadot): upgrade to v1.2.0#999

Closed
renauter wants to merge 11 commits into
developmentfrom
fix_upgrade_polkadot_1.2.0
Closed

fix(polkadot): upgrade to v1.2.0#999
renauter wants to merge 11 commits into
developmentfrom
fix_upgrade_polkadot_1.2.0

Conversation

@renauter
Copy link
Copy Markdown
Contributor

@renauter renauter commented Sep 3, 2024

Description

From previous PR #905:

  • Upgrade to Polkadot v1.2.0

    • update versions of clap and serde_json dependencies
    • add libp2p-identity dependency
    • add block_relay to sc_service::build_network()
    • pallet-smart-contract: use transfer_allow_death() instead of transfer()
    • add sp-genesis-builder dependency
    • implement sp_genesis_builder::GenesisBuilder<Block> for runtime
  • Complete PR chore(polkadot): upgrade to v1.2.0 #905 by adding:

About transferAllowDeath vs transferKeepAlive
Some documentation on how account is reaped and can be reactivated
https://medium.com/we-are-talisman/existential-deposit-1d3585e2d4d0

Related Issues:

Checklist:

@renauter renauter marked this pull request as ready for review September 3, 2024 11:53
@sameh-farouk
Copy link
Copy Markdown
Member

let's add the changes from the reverted commit here

@sameh-farouk sameh-farouk marked this pull request as draft February 13, 2025 09:58
@sameh-farouk
Copy link
Copy Markdown
Member

Closing this stale draft. The v1.2.0 upgrade was never landed — development remains on polkadot-sdk v1.1.0 — but this branch (last synced Oct 2024) is ~55 commits behind and conflicting, and v1.2.0 is itself now far behind upstream. The upgrade remains desirable, but as fresh work targeting a current SDK release rather than a rebase of this branch. Closing to clear the backlog; reopen/revive if a near-term v1.2.0 step is specifically planned. Thanks @renauter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants