Audio: Enhancing audio quality tests for device testing

For the purpose of remote device testing, this check-in
adds a correction to the scripts that evaluate gain,
frequency responsiveness, total harmonic distortion
plus noise, and dynamic range.

The threshold scale has been defined and the decibel
full scale computation has been made easier using new
scripts.

You require Octave or Matlab. The scripts now operate
properly in both Matlab and octave.

The user account, audio device, audio format, and
capture sound card audio device and audio format for the
remote device must be modified in the configuration file
sof test perf config.m.

Signed-off-by: shastry <malladi.sastry@intel.com>

Author: ShriramShastry

tools/test/audio/process_test.m

@@ -231,6 +231,8 @@
 
 % Measure
 test = thdnf_mask(test, t);
+
+% test = thdnf_mask(test); % correction
 test = thdnf_test_measure(test);
 
 % For EQ use the -20dBFS result and ignore possible -1 dBFS fail
@@ -357,8 +359,8 @@
 % Test constraints
 test.f_start = 20;
 test.f_end = test.fs * 0.41667; % 20 kHz @ 48 kHz
-test.fu = test.fs * 0.41667;    % 20 kHz @ 48 kHz
-test.f_max = 0.999*t.fs/2;      % Measure up to min. Nyquist frequency
+test.fu = test.fs * 0.41667;    % 20 kHz @ 48 kHz, duplicate variable/ instead use test.f_end
+test.f_max = 0.999*test.fs/2;   % Measure up to min. Nyquist frequency
 test.fs1 = test.fs;
 test.fs2 = test.fs;
 

tools/test/audio/sof_test_perf.m

@@ -29,7 +29,8 @@
 
 %% Plotting
 test.plot_close_windows = 1;    % Workaround for visible windows if Octave hangs
-test.plot_visible = 'off';      % Use off for batch tests and on for interactive
+% test.plot_visible = 'off';      % Use off for batch tests and on for interactive
+test.plot_visible = 'on';      % Use off for batch tests and on for interactive
 test.plot_passband_zoom = 1;    % Do a small plot box for only passband
 test.plot_channels_combine = 1; % Plot channels into same figure
 
@@ -46,8 +47,6 @@
 test = get_config(test);
 
 %% Run tests
-fail = 0;
-pass = 0;
 test.tf = [];
 
 % Check that the configuration has been edited
@@ -68,6 +67,9 @@
 
 	%% Total harmonic distortion plus noise
 	[tf(3), thdnf_low, thdnf_high] = thdnf_test(test);
+
+	%% Dynamic range
+	[tf(4), dynamic_range]= dr_test(test);
 end
 
 %% Print results
@@ -81,6 +83,7 @@
 	print_val(test, tf(2), fr_3db_hz / 1000, 'kHz', '-3 dB frequency');
 	print_val(test, tf(3), thdnf_low, 'dB', 'THD+N -20 dBFS');
 	print_val(test, tf(3), thdnf_high, 'dB', 'THD+N -1 dBFS');
+	print_val(test, tf(4), dynamic_range, 'dB', 'dr_db_min');
 else
 	fprintf(1, '\n');
 	fprintf(1, 'Warning: The gain test must pass before other tests are executed.\n');
@@ -128,8 +131,8 @@
 %% Reference: AES17 6.2.3 Frequency response
 c1 = 20/48;
 c2 = 23.9/48;
-test.f_lo = 20;            % Measure start at 20 Hz
-test.f_hi = c1 * test.fs;  % Measure end e.g. at 20 kHz
+test.fr_lo = 20;            % Measure start at 20 Hz
+test.fr_hi = c1 * test.fs;  % Measure end e.g. at 20 kHz
 test.f_max = c2 * test.fs; % Sweep max e.g. at 23.9 kHz
 
 %% Create input file
@@ -144,7 +147,7 @@
 
 fail = test.fail;
 fr_db = test.rp;
-fr_hz = [test.f_lo test.f_hi];
+fr_hz = [test.fr_lo test.fr_hi];
 fr_3db_hz = test.fr3db_hz;
 delete_check(test.files_delete, test.fn_in);
 delete_check(test.files_delete, test.fn_out);
@@ -182,6 +185,28 @@
 
 end
 
+%% Reference: AES17 6.4.1 Dynamic range
+function [fail, dr_db] = dr_test(t)
+
+test = test_defaults(t);
+
+% Create input file
+test = dr_test_input(test);
+
+% Run test
+% test = test_run_process(test, t);
+test = remote_test_run(test);
+
+% Measure
+test = dr_test_measure(test);
+
+% Get output parameters
+fail = test.fail;
+dr_db = test.dr_db;
+delete_check(test.files_delete, test.fn_in);
+delete_check(test.files_delete, test.fn_out);
+
+end
 %%
 %% Utilities
 %%

tools/test/audio/sof_test_perf_config.m

@@ -41,6 +41,12 @@
 test.fr_rp_max_db = 1.0;	     % Upper limit for p-p ripple in dB
 test.plot_fr_axis = [10 30e3 -4 1];  % Plot xmin, xmax, ymin, ymax
 
+test.fr_mask_flo = [];
+test.fr_mask_fhi = [];
+test.fr_mask_mlo = [];
+test.fr_mask_mhi = [];
 %% THD+N test case
 test.thdnf_max = -55;			   % Upper limit for THD+N
 test.plot_thdn_axis = [10 30e3 -90 -40]; % Plot xmin xmax ymin ymax
+%% dynamic range test case
+test.dr_db_min = 70;            % Min. DR,80dB

tools/test/audio/std_utils/dr_test_measure.m

@@ -57,7 +57,7 @@
 level_in = test.a_db;
 level_out = level_dbfs(y);
 level_final = level_dbfs(y_n);
-test.dr_db = level_out-level_final-test.a_db;
+test.dr_db = level_out - level_final - test.a_db;
 fprintf('DR = %5.1f dB\n', test.dr_db);
 if 0
         plot(y);

tools/test/audio/std_utils/fr_test_input.m

@@ -88,7 +88,7 @@
 test.tr = 10e-3; % Gain ramp time for tones
 test.sm = 3; % Seek start marker from 3s from start
 test.em = 3; % Seek end marker from 3s from end
-test.mt = 0.1; % Error if marker positions delta is greater than 0.1s
+test.mt = 2; % Error if marker positions delta is greater than 0.1s
 test.tc = 10; % Min. 10 cycles of sine wave for a frequency
 t_min = 0.1;
 % Use t_min or min cycles count as tone length

tools/test/audio/std_utils/fr_test_measure.m

@@ -33,15 +33,17 @@
 % Author: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
 
 %% Check if upper and lower mask is defined
-if length(test.fr_mask_flo) || length(test.fr_mask_fhi)
+if ~isempty(test.fr_mask_flo) || ~isempty(test.fr_mask_fhi)
 	test.fr_lo = 0;
 	test.fr_hi = 0;
 end
 if test.fr_lo > 0 || test.fr_hi > 0
-	test.fr_mask_flo = [];
-	test.fr_mask_fhi = [];
-	test.fr_mask_mlo = [];
-	test.fr_mask_mhi = [];
+	test.fr_mask_fhi = [20 test.f_max];
+	test.fr_mask_flo = [200 400 3500 3600 ];
+	for i = 1:test.nch
+		test.fr_mask_mhi(:,i) = [ 1 1 ];
+		test.fr_mask_mlo(:,i) = [-10 -1 -1 -10];
+	end
 end
 
 test.ph = [];
@@ -66,10 +68,10 @@
 
         %% Find sync
         [d, nt, nt_use, nt_skip] = find_test_signal(x(:,j), test);
-	if isempty(d)
-		test.fail = 1;
-		return
-	end
+		if isempty(d)
+			test.fail = 1;
+			return
+		end
 
         win = hamming(nt_use);
         m0 = zeros(test.nf,1);
@@ -87,16 +89,16 @@
         test.m(:,j) = m0 - m_offs;
 
         %% Check pass/fail
-	if test.fr_lo > 0 && test.fr_hi > 0 && ~isempty(test.fr_rp_max_db)
-		idx0 = find(test.f < test.fr_hi);
-		idx1 = find(test.f(idx0) > test.fr_lo);
-		range_db = max(test.m(idx1,j))-min(test.m(idx1,j));
-		test.rp(j) = range_db/2;
-		if test.rp(j) > test.fr_rp_max_db
-			fprintf('Failed response ch%d +/- %f dBpp (max +/- %f dB)\n', ...
-				test.ch(j), test.rp(j), test.fr_rp_max_db);
-			test.fail = 1;
-		end
+        if test.fr_lo > 0 && test.fr_hi > 0 && ~isempty(test.fr_rp_max_db)
+            idx0 = find(test.f < test.fr_hi);
+            idx1 = find(test.f(idx0) > test.fr_lo);
+            range_db = max(test.m(idx1,j))-min(test.m(idx1,j));
+            test.rp(j) = range_db/2;
+            if test.rp(j) > test.fr_rp_max_db
+                fprintf('Failed response ch%d +/- %f dBpp (max +/- %f dB)\n', ...
+                    test.ch(j), test.rp(j), test.fr_rp_max_db);
+                test.fail = 1;
+            end
         end
 
         %% Find frequency response 3 dB 0-X Hz
@@ -109,7 +111,7 @@
                 mask_hi = interp1(log(test.fr_mask_fhi), ...
 				  test.fr_mask_mhi(:,j), f_log, 'linear');
                 over_mask = test.m(:,j)-mask_hi';
-                idx = find(isnan(over_mask) == 0);
+                idx = ~isnan(over_mask);
                 [m_over_mask, io] = max(over_mask(idx));
                 if m_over_mask > 0
                         fprintf('Failed upper response mask around %.0f Hz\n', ...
@@ -122,7 +124,7 @@
                 mask_lo = interp1(log(test.fr_mask_flo), ...
 				  test.fr_mask_mlo(:,j), f_log, 'linear');
                 under_mask = mask_lo'-test.m(:,j);
-                idx = find(isnan(under_mask) == 0);
+                idx = ~isnan(under_mask);
                 [m_under_mask, iu] = max(under_mask(idx));
                 if m_under_mask > 0
                         fprintf('Failed lower response mask around %.0f Hz\n', ...

tools/test/audio/std_utils/level_dbfs.m

@@ -6,15 +6,14 @@
 % x - signal
 %
 % Output
-% dbfs - sigmal level in dBFS
+% dbfs - signal level in dBFS
 %
 
 % SPDX-License-Identifier: BSD-3-Clause
 % Copyright(c) 2017 Intel Corporation. All rights reserved.
 % Author: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
 
 %% Reference AES 17 3.12.3
-level_ms = mean(x.^2);
-dbfs = 10*log10(level_ms + 1e-20) + 20*log10(sqrt(2));
+dbfs = 20*log10(rms(x) * sqrt(2));
 
 end

tools/test/audio/std_utils/thdnf_test_input.m

@@ -59,7 +59,7 @@
 test.tr = 10e-3; % Gain ramp time for tones
 test.sm = 3; % Seek start marker from 3s from start
 test.em = 3; % Seek end marker from 3s from end
-test.mt = 0.1; % Error if marker positions delta is greater than 0.1s
+test.mt = 2; % Error if marker positions delta is greater than 0.1s
 test.a_db = [-1 -20]; % -1 and -20 dBFS levels
 test.a = 10.^(test.a_db/20);
 test.tl = 4; % 3 seconds tone

tools/test/audio/std_utils/thdnf_test_measure.m

@@ -7,18 +7,14 @@
 test.ph = [];
 test.fh = [];
 
-if isempty(test.thdnf_mask_f)
-	if ~isempty(test.thdnf_max)
-		test.thdnf_mask_f = [1 test.fs/2]; % Start from 1 due to log()
-		test.thdnf_mask_hi = test.thdnf_max * [1 1];
-	end
-else
-	if ~isempty(test.thdnf_max)
-		error('Set either thdnf_max or thdnf_mask_f & thdnf_mask_hi but not both');
-	end
-	if isempty(test.thdnf_mask_hi)
-		error('thdnf_mask_hi must be set when thdnf_mask_f is defined');
-	end
+if ~isempty(test.thdnf_max)
+    test.thdnf_mask_f = [1 test.fs/2]; % Start from 1 due to log()
+    test.thdnf_mask_hi = test.thdnf_max * [1 1];
+end
+if isempty(test.thdnf_max)
+    error('Set either thdnf_max or thdnf_mask_f & thdnf_mask_hi but not both');
+elseif isempty(test.thdnf_mask_hi)
+    error('thdnf_mask_hi must be set when thdnf_mask_f is defined');
 end
 
 %% Reference: AES17 6.3.2 THD+N ratio vs frequency
@@ -76,16 +72,16 @@
 	test.thdnf_high(:,i) = test.thdnf(:,1);
 	test.thdnf_low(:,i) = test.thdnf(:,2);
 
-	fidx = find(test.thdnf(idx, 1) > mask_hi);
-	if length(fidx) > 0
+	fidx = find(test.thdnf(idx, 1) > mask_hi, 1);
+	if ~isempty(fidx)
 		fail_hi = 1;
 		fprintf('Failed THD+N mask with high input.\n');
 	else
 		fail_hi = 0;
 	end
 
-	fidx = find(test.thdnf(idx, 2) > mask_hi);
-	if length(fidx) > 0
+	fidx = find(test.thdnf(idx, 2) > mask_hi, 1);
+	if ~isempty(fidx)
 		fail_lo = 1;
 		fprintf('Failed THD+N mask with low input.\n');
 	else

tools/test/audio/test_utils/find_test_signal.m

@@ -21,7 +21,7 @@
 nt = [];
 nt_use = [];
 nt_skip = [];
-
+trace_en = false; % Enable to trace algirithm -analysis
 %% Use channel with strongest signal
 ch = select_channel(x0);
 x = x0(:, ch);
@@ -35,37 +35,66 @@
 y = x(1:n);
 [r, lags] = xcorr(y, s);
 r2 = r.^2;
-r2_thr = 0.1 * max(r2);
+r2_thr = mean(abs(r2)) + std(abs(r2))*3; %1/3rd of Max value
 idx = find(r2 > r2_thr);
 d_start = lags(idx(1));
 
+fprintf('Finding test start marker.up\n');
+
+if isequal(trace_en,true)
+    fprintf(['%20s|%20s|%20s|%20s|%20s|%20s|%20s|%20s|\n--------------------+--------------------+--------------------+----' ...
+        '----------------+--------------------+--------------------+--------------------+--------------------+\n'], ...
+        'nx', 'n_seek', 'test.fs', 'test.idle_t', 'test.mark_t', 'test.sm', 'n','d_start');
+
+    fprintf('%20d|%20d|%20d|%20.6f|%20.6f|%20d|%20d|%20d|\n',nx, n_seek, test.fs, test.idle_t, test.mark_t, test.sm, n,d_start);
+end
+
+
 %% Find end marker
 fprintf('Finding test end marker...\n');
 s = sync_chirp(test.fs, 'down');
+
+nx = length(x);
 n_seek = round(test.fs*(test.idle_t + test.mark_t));
 n = min(max(round(test.fs*test.em),n_seek), nx);
 y = x(end-n+1:end);
 [r, lags] = xcorr(y, s);
 r2 = r.^2;
-r2_thr = 0.1 * max(r2);
+
+r2_thr = mean(abs(r2)) + std(abs(r2))*3; %1/3rd of Max value
 idx = find(r2 > r2_thr);
 d_end = nx-n+lags(idx(end));
 
+fprintf('Finding test start marker.down\n');
+if isequal(trace_en,true)
+    fprintf(['%20s|%20s|%20s|%20s|%20s|%20s|%20s|%20s|%20s|\n--------------------+--------------------+--------------------+----' ...
+        '----------------+--------------------+--------------------+--------------------+--------------------+--------------------+\n'], ...
+        'nx', 'n_seek', 'test.fs', 'test.idle_t', 'test.mark_t', 'test.sm', 'n','d_start','d_end');
+    fprintf('%20d|%20d|%20d|%20.6f|%20.6f|%20d|%20d|%20d|%20d|\n',nx, n_seek, test.fs, test.idle_t, test.mark_t, test.sm, n,d_start,d_end);
+
+end
+
+
 %% Check correct length of signal
 len = d_end-d_start;
 len_s = len/test.fs;
 ref_s = test.mark_t+test.nf*test.na*test.tl;
-if abs(len_s-ref_s) > test.mt
-        fprintf(1, 'Start and end markers were not found. Signal quality may be poor.\n');
-	return
+
+if isequal(trace_en,true)
+    fprintf(['%20s|%20s|%20s|%20s|\n--------------------+--------------------+' ...
+        '--------------------+--------------------+\n'],'len_s', 'ref_s', 'test.mt','abs(len_s - ref_s)');
+    fprintf('%20f|%20f|%20f|%20f|\n', len_s, ref_s, test.mt,abs(len_s - ref_s));
+end
+if abs(len_s - ref_s) > test.mt %FR , THD, DR,Relaxation may be required.
+    fprintf(1, 'Start and end markers were not found. Signal quality may be poor.\n');
+    return
 end
 
 %% Delay to first tone, length of tone in samples
 d = d_start + round(test.mark_t*test.fs);
 if (d < 0)
 	fprintf(1, 'Invalid delay value. Signal quality may be poor.\n');
 	return
-	d = [];
 end
 nt = round(test.tl*test.fs);
 nt_use = nt -round(test.is*test.fs) -round(test.ie*test.fs);
@@ -92,6 +121,6 @@
 	nch = s(2);
 	rms_db = zeros(1, nch);
 	for i = 1:nch
-		rms_db(i) = 20*log10(sqrt(mean(x(:,i).^2)));
+        rms_db(i) = 20*log10(rms(x(:,i)));% very small data
 	end
 end