Skip to content

Commit 64d0284

Browse files
committed
ASoC: SOF: loader: do not warn about unknown firmware manifest headers
The firmware manifest is designed to be extendable without breaking the driver-firmware ABI. Driver should not raise a warning in case a new manifest header type is detected at firmware boot. There are already checks for IPC ABI compatibility in snd_sof_ipc_valid() and if the versions are deemed compatible, extra fields in IPC messages should not trigger warnings. As runtime pm is enabled on most platforms and snd_sof_fw_parse_ext_data() is called for every DSP boot, this creates unnessary kernel dmesg fraffic. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
1 parent f6cc092 commit 64d0284

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

sound/soc/sof/loader.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,8 @@ int snd_sof_fw_parse_ext_data(struct snd_sof_dev *sdev, u32 bar, u32 offset)
124124
/* They are supported but we don't do anything here */
125125
break;
126126
default:
127-
dev_warn(sdev->dev, "warning: unknown ext header type %d size 0x%x\n",
128-
ext_hdr->type, ext_hdr->hdr.size);
127+
dev_dbg(sdev->dev, "unknown ext header type %d size 0x%x\n",
128+
ext_hdr->type, ext_hdr->hdr.size);
129129
ret = 0;
130130
break;
131131
}

0 commit comments

Comments
 (0)