The 'clean' task is already present#55
Merged
maestromac merged 1 commit intoforem:masterfrom Oct 21, 2019
Merged
Conversation
|
|
The new added custom task ':clean' is redundant as the project itself has a configuration already set for cleaning the project. The new task only adds the posibility of being called with './gradlew :clean' instead of './gradlew clean' issue with this custom task is that it only clears the 'rootProject.buildDir' but currently the project has four build directories: * app/build * buildSrc/build * data/build * baseui/build These directories should be cleaned on every call of the clean task and adding a new task for it seems redundant
45b335d to
3c39e04
Compare
VarunBarad
approved these changes
Oct 17, 2019
maestromac
approved these changes
Oct 21, 2019
Contributor
maestromac
left a comment
There was a problem hiding this comment.
Thanks for this @sierisimo !
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The new added custom task ':clean' is redundant as the project itself has a configuration already set for cleaning the project.
The new task only adds the posibility of being called with './gradlew :clean' instead of './gradlew clean' issue with this custom task is that it only clears the 'rootProject.buildDir' but currently the project has four build directories:
These directories should be cleaned on every call of the clean task and adding a new task for it seems redundant.
Other possible option is to add the cleanup by hand:
But gradle does something similar to this. No actual need to process anything…
Related Tickets & Documents
[optional] What gif best describes this PR or how it makes you feel?