Bug/save webview state retain history#52
Merged
maestromac merged 3 commits intoforem:masterfrom Oct 20, 2019
sduduzog:bug/save-webview-state-retain-history
Merged
Bug/save webview state retain history#52maestromac merged 3 commits intoforem:masterfrom sduduzog:bug/save-webview-state-retain-history
maestromac merged 3 commits intoforem:masterfrom
sduduzog:bug/save-webview-state-retain-history
Conversation
|
|
sierisimo
previously approved these changes
Oct 14, 2019
VarunBarad
reviewed
Oct 14, 2019
app/src/main/java/to/dev/dev_android/view/main/view/MainActivity.kt
Outdated
Show resolved
Hide resolved
sierisimo
approved these changes
Oct 14, 2019
dbaelz
approved these changes
Oct 19, 2019
dbaelz
approved these changes
Oct 19, 2019
maestromac
approved these changes
Oct 20, 2019
Contributor
maestromac
left a comment
There was a problem hiding this comment.
While I personally can't reproduce this bug, I see no harm in having this change in place. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR has work that enables the webview to save it's state when the app is sent to the background and restores it when brought back to the foreground. Should there be no state, the app will load the base url as defaulted.
Related Tickets & Documents
This PR resolves #48
Screenshots/Recordings (if there are UI changes)
[optional] What gif best describes this PR or how it makes you feel?