Merged
Conversation
* Fixed Kotlin Stdlib into jdk8 instead of jdk7 * Moved in data/build.gradle the order of plugins applied (it throws an error or a warning depending on configurations) * Updated the versions of libraries: * androidx.test:runner 1.1.1 -> 1.2.0 * androidx.test.espresso:espresso-core 3.1.1 -> 3.2.0
|
|
maestromac
approved these changes
Jun 20, 2019
Contributor
maestromac
left a comment
There was a problem hiding this comment.
Awesome! Thanks for this @sierisimo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
I'm trying to contribute to the project, my first thing to give is an update to the libs in the project, we can move into JDK8 for kotlin and the compilation rules. This is mostly a suggestion given some libraries will throw errors if not compiling with JDK8.
Also…
data/build.gradlethe order of plugins applied (it throws an error or a warning depending on configurations) for kotlin. The warning/error states thatkotlin-androidshould come before `kotlin-android-extensions[optional] What gif best describes this PR or how it makes you feel?