#291 Docker for Windows by bsideup · Pull Request #297 · testcontainers/testcontainers-java

bsideup · 2017-02-22T09:49:03Z

No description provided.

kiview · 2017-02-24T00:08:38Z

Great experience using this on Windows. Just tested it on my Windows Laptop and was happy to see I didn't have to configure any additional JVM properties or ENV variables (I think the docker-java lib behaved differently).

However, docker-compose doesn't seem to work for me in the current implementation. I get the following error i.e. in DockerComposeV2FormatTest:

org.testcontainers.containers.ContainerLaunchException: Container startup failed

	at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:179)
	at org.testcontainers.containers.ContainerisedDockerCompose.start(DockerComposeContainer.java:423)
	at org.testcontainers.containers.DockerComposeContainer.pullImages(DockerComposeContainer.java:120)
	at org.testcontainers.containers.DockerComposeContainer.starting(DockerComposeContainer.java:106)
	at org.testcontainers.containers.FailureDetectingExternalResource$1.evaluate(FailureDetectingExternalResource.java:28)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:237)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147)
Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
	at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:83)
	at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:172)
	... 25 more
Caused by: java.lang.NullPointerException: containerId was not specified
	at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:228)
	at com.github.dockerjava.core.command.LogContainerCmdImpl.withContainerId(LogContainerCmdImpl.java:78)
	at com.github.dockerjava.core.command.LogContainerCmdImpl.<init>(LogContainerCmdImpl.java:38)
	at com.github.dockerjava.core.DockerClientImpl.logContainerCmd(DockerClientImpl.java:335)
	at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:236)
	at org.testcontainers.containers.GenericContainer.lambda$start$0(GenericContainer.java:174)
	at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:76)
	... 26 more

I've got the same error in the docker-compose tests of my spock extension.

rnorth · 2017-03-01T20:14:37Z

Has anyone looked into this apparent problem with Compose when using this approach?

kiview · 2017-03-01T20:16:19Z

Can someone else reproduce the error I've posted?

bsideup · 2017-03-01T20:16:57Z

@rnorth it seems like a problem with Docker Compose integration on Windows, not the Docker for Windows itself.
I'll test it a little bit more (I have a Windows PC to experiment), if it's not related to this change (Docker for Windows support) I would rather create the follow-up tasks

@kiview I can, fails on my machine too

rnorth · 2017-03-01T20:18:48Z

👍 sure, we can split compose support for windows if we have to.

I was just wondering whether there's something unsafe about the approach of volume mounting the docker socket (here) on Docker for Windows. It would seem unlikely, but I can't think of many other things it could be.

bsideup · 2017-03-01T20:21:14Z

@rnorth could be
or "createMinGWPath" workaround, I'm not sure that it's needed on Docker for Windows

kiview · 2017-03-01T20:25:03Z

I think the mounting does nothing or might create an empty directory somewhere. Not sure though.
+1 for integrating this branch and fixing the Docker-Compose support in another task.

rnorth

Looks good to me - only trivial comments

rnorth · 2017-03-01T20:29:06Z

+public class WindowsClientProviderStrategy extends DockerClientProviderStrategy {
+
+    private static final int PING_TIMEOUT_DEFAULT = 5;
+    private static final String PING_TIMEOUT_PROPERTY_NAME = "testcontainers.namedpipesocketprovider.timeout";


Should probably change this name since we're not using named pipes

rnorth · 2017-03-01T20:29:47Z

 | Mac OS X - Docker for Mac      | 1.12.0          | *Support is best-efforts at present*. `getTestHostIpAddress()` is [not currently supported](https://github.com/testcontainers/testcontainers-java/issues/166) due to limitations in Docker for Mac. |
 | Windows - Docker Toolbox            |                             | *Support is limited at present and this is not currently tested on a regular basis*.                                                                                                                                                                                                                                                                               |
-| Windows - Docker for Windows Beta   |                             | *Not currently supported*.                                                                                                                                                                                                                                                                                                                                         |
+| Windows - Docker for Windows   |                             | *Supported, but not currently tested on a regular basis.*                                                                                                                                                                                                                                                                                                                                        |


Let's just add the note re Docker Compose not currently working, then 👍

…tests in the docs

bsideup · 2017-03-02T06:46:24Z

@rnorth I did the changes you requested, please take another look

rnorth · 2017-03-03T08:22:03Z

Looks good to me, thanks @bsideup !

## [1.2.0] - 2017-03-12 ### Fixed - Fix various escaping issues that may arise when paths contain spaces (#263, #279) - General documentation fixes/improvements (#300, #303, #304) - Improve reliability of `ResourceReaper` when there are a large number of containers returned by `docker ps -a` (#295) ### Changed - Support Docker for Windows via TCP socket connection (#291, #297, #309). _Note that Docker Compose is not yet supported under Docker for Windows (see #306) - Expose `docker-java`'s `CreateContainerCmd` API for low-level container tweaking (#301) - Shade `org.newsclub` and Guava dependencies (#299, #292) - Add `org.testcontainers` label to all containers created by Testcontainers (#294)

bsideup added 2 commits February 22, 2017 11:45

#291 Docker for Windows support over TCP

63a57d6

#291 relax the condition

73accee

bsideup requested a review from rnorth February 22, 2017 09:52

bsideup self-assigned this Feb 22, 2017

bsideup added client/docker-for-windows enhancement labels Feb 22, 2017

bsideup added this to the 1.1.10 milestone Feb 22, 2017

Closes #291 change the docs

7fbec54

Villane mentioned this pull request Feb 22, 2017

Docker for Windows support #291

Closed

rnorth requested changes Mar 1, 2017

View reviewed changes

Rename PING_TIMEOUT_PROPERTY_NAME and mention failing Docker Compose …

dbf6dbc

…tests in the docs

rnorth merged commit 9b8207e into master Mar 3, 2017

rnorth deleted the 291-docker_for_windows branch March 3, 2017 08:22

rnorth mentioned this pull request Mar 3, 2017

Resolve issues with Docker Compose when running under Docker for Windows #306

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

#291 Docker for Windows#297

#291 Docker for Windows#297
rnorth merged 4 commits into
masterfrom
291-docker_for_windows

bsideup commented Feb 22, 2017

Uh oh!

kiview commented Feb 24, 2017

Uh oh!

rnorth commented Mar 1, 2017

Uh oh!

kiview commented Mar 1, 2017

Uh oh!

bsideup commented Mar 1, 2017

Uh oh!

rnorth commented Mar 1, 2017

Uh oh!

bsideup commented Mar 1, 2017

Uh oh!

kiview commented Mar 1, 2017

Uh oh!

rnorth left a comment

Uh oh!

rnorth Mar 1, 2017

Uh oh!

rnorth Mar 1, 2017

Uh oh!

bsideup commented Mar 2, 2017

Uh oh!

rnorth commented Mar 3, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

bsideup commented Feb 22, 2017

Uh oh!

kiview commented Feb 24, 2017

Uh oh!

rnorth commented Mar 1, 2017

Uh oh!

kiview commented Mar 1, 2017

Uh oh!

bsideup commented Mar 1, 2017

Uh oh!

rnorth commented Mar 1, 2017

Uh oh!

bsideup commented Mar 1, 2017

Uh oh!

kiview commented Mar 1, 2017

Uh oh!

rnorth left a comment

Choose a reason for hiding this comment

Uh oh!

rnorth Mar 1, 2017

Choose a reason for hiding this comment

Uh oh!

rnorth Mar 1, 2017

Choose a reason for hiding this comment

Uh oh!

bsideup commented Mar 2, 2017

Uh oh!

rnorth commented Mar 3, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants