Skip to content

Expose reaper's trigger to public API#231

Merged
rnorth merged 2 commits into
testcontainers:masterfrom
zeroturnaround:manual-reaper
Nov 7, 2016
Merged

Expose reaper's trigger to public API#231
rnorth merged 2 commits into
testcontainers:masterfrom
zeroturnaround:manual-reaper

Conversation

@bsideup
Copy link
Copy Markdown
Member

@bsideup bsideup commented Oct 11, 2016

Hi

Sometimes there is a need to trigger ResourceReaper, especially in non-JUnit environments (i.e. Cucumber-JVM)

Method is marked as synchronized to avoid concurrency access.

/**
* Perform a cleanup.
*
*/
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could this be named performCleanup if it's a public API method?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

@rnorth rnorth merged commit 4e284ec into testcontainers:master Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants