perf: add BufWriter to Stderr to avoid frequent system calls and increase rendering frame rate
#849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…increase rendering frame rate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue reported by @DreamMaoMao on Yazi's Discord server, https://discord.com/channels/1136203602898194542/1136203604076802092/1223142137860984943
This PR fixes a performance regression introduced by the latest main branch. Recently, Yazi switched from
stdouttostderr, but sincestderris unbuffered (previouslystdoutwas line-buffered, i.e.LineWriter), this change caused a decrease in rendering frame rate.This PR adds a block buffer (
BufWriter) tostderr, while solving this performance regression, it theoretically can further improve performance - this is an example comparingLineWriterandBufWriter, https://github.com/orhun/rust-stdout-vs-stderr(Image source: https://github.com/orhun/rust-stdout-vs-stderr)