fix: ignore stdin redirection to ensure always accessing the real tty #2425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 1, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Mar 6, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [sxyazi/yazi](https://github.com/sxyazi/yazi) | minor | `v25.2.26` -> `v25.3.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>sxyazi/yazi (sxyazi/yazi)</summary> ### [`v25.3.2`](https://github.com/sxyazi/yazi/releases/tag/v25.3.2) [Compare Source](sxyazi/yazi@v25.2.26...v25.3.2) This is a quick fix release that addresses the issue where, under SSH, terminal response sequences are not completely consumed and are leaked to the screen. Thanks to [@​Crdr0122](https://github.com/Crdr0122) and [@​SpookyYomo](https://github.com/SpookyYomo) for reporting and helping reproduce the issue! #### What's Changed - feat: expose all theme fields in Lua by [@​hankertrix](https://github.com/hankertrix) in sxyazi/yazi#2405 - fix: `windows-sys` features for `Win32_Storage_FileSystem` and `Win32_System_Threading` by [@​sxyazi](https://github.com/sxyazi) in sxyazi/yazi#2417 - fix: ignore stdin redirection to ensure always accessing the real tty by [@​sxyazi](https://github.com/sxyazi) in sxyazi/yazi#2425 - fix: `STDIN_FILENO` poll always returns 0 under SSH by [@​sxyazi](https://github.com/sxyazi) in sxyazi/yazi#2427 - feat: expose almost the entirety of the user's configuration in Lua by [@​hankertrix](https://github.com/hankertrix) in sxyazi/yazi#2413 - chore: bump version to 25.3.2 by [@​sxyazi](https://github.com/sxyazi) in sxyazi/yazi#2428 **Full Changelog**: sxyazi/yazi@v25.2.26...v25.3.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODIuNCIsInVwZGF0ZWRJblZlciI6IjM5LjE4Mi40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
|
Can I ask, this is a fix for yazi itself not being redirected and reading/writing to somewhere else? As in the fix isn't supposed to make yazi appear as the TTY when receiving output from another program is it? I just ask because with my plugin I was having some issues getting duckdb to send it's output as if to the TTY (including ansi codes). I'm pretty sure the issue is duckdb cleaning its output if it detects it's not directly to the TTY. I foud a workaround on Mac OS by issuing the command to "script" which then issues the duckdb command and duckdb sees it as the TTY. I'm working on a solution for linux and windows but I just wanted to check there wasn't something built in that was supposed to be doing this already? |
Lemi0002
pushed a commit
to Lemi0002/yazi
that referenced
this pull request
Apr 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2421
Fixes #2423