fix: remove ignore options from rg and fd search
#1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `yazi`'s `hidden` option is true, it passes `--no-ignore` to `fd` and `rg`. However, ignore files have no actual relation to hidden files. They often contain entries like `node_modules` or `vendor` that users want to ignore in all situations.
sxyazi
reviewed
May 16, 2024
ignore options from rg and fdignore options from rg and fd search
sxyazi
approved these changes
May 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
yazi'shiddenoption is true, it passes--no-ignoretofdandrg. However, ignore files have no actual relation to hidden files. They often contain entries likenode_modulesthat users want to ignore in all situations.Example use case: In a code project, I turn on the
hiddenoption to navigate to configuration files like.editorconfigand search their contents with S. I do not want thehiddenoption to expose thousands of search results innode_modules,.gocache, ordist.