Skip to content

Conversation

@knelli2
Copy link
Contributor

@knelli2 knelli2 commented Jul 29, 2025

Proposed changes

Sixteenth PR in horizon finder changes. Includes editing RunCallbacks to conform to the new ah::protocols::Callback protocol and editing the submeasurement protocol to accept horizon metavars.

Note that none of the new AH infrastructure is used in any executables yet. This is that last PR before changing the executables to use the new infrastructure.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Includes editing RunCallbacks to conform to the new
ah::protocols::Callback protocol and editing the submeasurement
protocol to accept horizon metavars.

Note that none of the new AH infrastructure is used in any
executables yet.
@knelli2 knelli2 added this to the AH finder improvements milestone Jul 29, 2025
@knelli2 knelli2 requested a review from wthrowe July 29, 2025 23:45
@wthrowe wthrowe merged commit 6987114 into sxs-collaboration:develop Jul 31, 2025
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants