AH rewrite: Add AH protocols #6742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wthrowe
requested changes
Jul 9, 2025
|
|
||
| #pragma once | ||
|
|
||
| #include "ParallelAlgorithms/ApparentHorizonFinder/Destination.hpp" |
| using horizon_find_callbacks = | ||
| typename ConformingType::horizon_find_callbacks; | ||
| using horizon_find_failure_callbacks = | ||
| typename ConformingType::horizon_find_failure_callbacks; |
Member
There was a problem hiding this comment.
Check that the callbacks conform to the Callback protocol.
| #include "ParallelAlgorithms/ApparentHorizonFinder/Protocols/Callback.hpp" | ||
| #include "ParallelAlgorithms/ApparentHorizonFinder/Protocols/HorizonMetavars.hpp" | ||
| #include "ParallelAlgorithms/ApparentHorizonFinder/Tags.hpp" | ||
| #include "Utilities/ProtocolHelpers.hpp" |
Member
There was a problem hiding this comment.
<optional>, <string>, Gsl.hpp, TMPL.hpp
wthrowe
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Third PR for the new horizon finder that adds necessary protocols.
Depends on and includes #6741.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments