Skip to content

Conversation

@ffoucart
Copy link
Contributor

@ffoucart ffoucart commented Apr 7, 2025

Proposed changes

Add a mutator responsible for summing the contributions to the coupling between fluid and Monte-Carlo gathered from ghost zones to the values stored locally from the evolution of MC packets in live zones.

Upgrade instructions

NA

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Depends on #6550

@ffoucart
Copy link
Contributor Author

ffoucart commented Apr 7, 2025

The first commit of this PR is just #6550 . Only the second commit is relevant. There is a minor change to the test that checks work from 6550, but as the test didn't catch any error, i just kept it in this PR.

@knelli2 knelli2 added the dependent Needs a different PR to be merged in first label Apr 7, 2025
@ffoucart ffoucart force-pushed the GhostZoneCommMCSumFluidCoupling branch from 35f91f5 to 8a9f737 Compare April 7, 2025 19:42
// mesh, with ghost zones.
index_3d[dimension] =
(side == Side::Lower)
? index_3d[dimension] + num_ghost_zones
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why isn't this just index_3d[dimension]?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a much longer comment. I assume that the difference with what you imagine is that we are copying from the ghost zones of the neighbor onto the live points of the current mesh (rather than the other way around, usually), and all meshes used here include ghost points in their indexing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, thanks, the comment helps a lot

@ffoucart ffoucart force-pushed the GhostZoneCommMCSumFluidCoupling branch from 8a9f737 to 03ac25c Compare April 9, 2025 20:41
@ffoucart
Copy link
Contributor Author

ffoucart commented Apr 9, 2025

Updated after rebasing on merged PR #6550 and adding a comment to address Larry's question.

@ffoucart ffoucart removed the dependent Needs a different PR to be merged in first label Apr 9, 2025
@ffoucart ffoucart marked this pull request as ready for review April 9, 2025 20:43
@kidder kidder merged commit 9fae30c into sxs-collaboration:develop Apr 22, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants