Implemented DJANGO_EASY_AUDIT_PROPAGATE_EXCEPTIONS setting
#248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschoettle
suggested changes
Mar 20, 2023
Contributor
mschoettle
left a comment
There was a problem hiding this comment.
I am not a maintainer so am providing community feedback. Added a couple of comments.
I like this extra setting. Every once in a while I see some exceptions in pytest output that are suppressed.
Contributor
Author
|
Hi @jheld , I reworked PR for a single setting and added test. |
mschoettle
reviewed
Apr 1, 2023
Contributor
mschoettle
left a comment
There was a problem hiding this comment.
Looks great, thanks!
There are a few lines (raises e) where no should_propagate_exceptions() is called first. Are those checks missing there?
Contributor
Author
I only modified top-level try/catch blocks, not sure if we need to change inner ones. |
DJANGO_EASY_AUDIT_DEBUG_SIGNALS settingDJANGO_EASY_AUDIT_PROPAGATE_EXCEPTIONS setting
Contributor
Author
|
Hi, how can we proceed with this? |
jheld
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jheld ,
This is a PR for #247 , let me know if there's something I need to change.