Skip to content

Commit 807154a

Browse files
authored
Merge pull request #26 from sideprotocol/sufay/wrap-error-msg
Wrap specific error msg
2 parents 2d2e609 + de2c456 commit 807154a

1 file changed

Lines changed: 9 additions & 7 deletions

File tree

x/btcbridge/keeper/keeper_tss.go

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"time"
55

66
sdk "github.com/cosmos/cosmos-sdk/types"
7+
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
78

89
"github.com/sideprotocol/side/x/btcbridge/types"
910
)
@@ -176,11 +177,11 @@ func (k Keeper) CompleteDKG(ctx sdk.Context, req *types.DKGCompletionRequest) er
176177
}
177178

178179
if dkgReq.Status != types.DKGRequestStatus_DKG_REQUEST_STATUS_PENDING {
179-
return types.ErrInvalidDKGCompletionRequest
180+
return sdkerrors.Wrap(types.ErrInvalidDKGCompletionRequest, "invalid dkg request status")
180181
}
181182

182183
if !ctx.BlockTime().Before(*dkgReq.Expiration) {
183-
return types.ErrInvalidDKGCompletionRequest
184+
return sdkerrors.Wrap(types.ErrInvalidDKGCompletionRequest, "dkg request expired")
184185
}
185186

186187
if err := k.CheckVaults(ctx, req.Vaults); err != nil {
@@ -190,7 +191,7 @@ func (k Keeper) CompleteDKG(ctx sdk.Context, req *types.DKGCompletionRequest) er
190191
consAddress, _ := sdk.ConsAddressFromHex(req.ConsensusAddress)
191192
validator, found := k.stakingKeeper.GetValidatorByConsAddr(ctx, consAddress)
192193
if !found {
193-
return types.ErrInvalidDKGCompletionRequest
194+
return sdkerrors.Wrap(types.ErrInvalidDKGCompletionRequest, "non validator")
194195
}
195196

196197
pubKey, err := validator.ConsPubKey()
@@ -199,7 +200,7 @@ func (k Keeper) CompleteDKG(ctx sdk.Context, req *types.DKGCompletionRequest) er
199200
}
200201

201202
if !types.VerifySignature(req.Signature, pubKey.Bytes(), req) {
202-
return types.ErrInvalidDKGCompletionRequest
203+
return sdkerrors.Wrap(types.ErrInvalidDKGCompletionRequest, "invalid signature")
203204
}
204205

205206
k.SetDKGCompletionRequest(ctx, req)
@@ -211,9 +212,10 @@ func (k Keeper) CompleteDKG(ctx sdk.Context, req *types.DKGCompletionRequest) er
211212
func (k Keeper) CheckVaults(ctx sdk.Context, vaults []string) error {
212213
currentVaults := k.GetParams(ctx).Vaults
213214

214-
if len(vaults) != len(currentVaults) {
215-
return types.ErrInvalidDKGCompletionRequest
216-
}
215+
// commented out for now
216+
// if len(vaults) != len(currentVaults) {
217+
// return sdkerrors.Wrap(types.ErrInvalidDKGCompletionRequest, "invalid vaults")
218+
// }
217219

218220
for _, v := range vaults {
219221
if types.SelectVaultByAddress(currentVaults, v) != nil {

0 commit comments

Comments
 (0)