Skip to content

Support React 18+ in peerDeps #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobbieTheWagner merged 2 commits into from
Jan 29, 2026
+31 −42
Merged

Support React 18+ in peerDeps #3339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e447ac
Support React 17+ in peerDeps
RobbieTheWagner Jan 28, 2026
0197b0a
Update package.json
RobbieTheWagner Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,16 @@
"@vitejs/plugin-react": "^4.7.0",
"@vitest/ui": "^4.0.16",
"happy-dom": "^20.0.11",
"react": "^19.2.4",
"react-dom": "^19.2.4",
"typescript": "^5.9.3",
"vite": "^7.3.0",
"vite-plugin-dts": "^4.5.4",
"vitest": "^4.0.16"
},
"peerDependencies": {
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^18.0.0 || ^19.0.0",
"react-dom": "^18.0.0 || ^19.0.0",
Comment on lines +50 to +51
Copy link

@coderabbitai coderabbitai bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

PR title/description mismatch: actual support is React 18+, not React 17+.

The peerDependencies now correctly support React 18 and 19, which resolves the original issue #3102 (React 19 installation failure). However, the PR title claims "Support React 17+" while the implementation only supports ^18.0.0 || ^19.0.0.

Consider updating the PR title/description to accurately reflect "Support React 18 and 19" to avoid user confusion. This is especially relevant since the @testing-library/react v16 dependency (line 37) requires React 18+, making React 17 support impractical without additional changes.

🤖 Prompt for AI Agents 
In `@packages/react/package.json` around lines 50 - 51, Update the PR title and
description to accurately state supported React versions: change any "Support
React 17+" wording to "Support React 18 and 19" (or "Support React 18+" if you
prefer broader phrasing) to match the peerDependencies entries "react" and
"react-dom" which are set to "^18.0.0 || ^19.0.0" and to reflect the
`@testing-library/react` v16 requirement; ensure both the PR title and body
consistently mention React 18/19 support so they align with the package.json
declarations.

"typescript": "^5.0.0"
},
"publishConfig": {
Expand Down
67 changes: 27 additions & 40 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.