Skip to content

Commit cb31337

Browse files
Use $state for things that are not passed
1 parent b8c38d0 commit cb31337

2 files changed

Lines changed: 10 additions & 9 deletions

File tree

shepherd.js/src/components/shepherd-element.svelte

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,17 @@
1010
1111
let {
1212
classPrefix,
13-
element = $bindable(),
1413
descriptionId,
15-
firstFocusableElement,
16-
focusableElements,
1714
labelId,
18-
lastFocusableElement,
19-
step,
20-
dataStepId
15+
step
2116
} = $props();
2217
23-
let classes;
18+
let classes = $state();
19+
let dataStepId = $state();
20+
let element = $state();
21+
let firstFocusableElement = $state();
22+
let focusableElements = $state();
23+
let lastFocusableElement = $state();
2424
2525
const hasCancelIcon = $derived(step.options?.cancelIcon?.enabled ?? false);
2626
const hasTitle = $derived(step.options?.title ?? false);

shepherd.js/src/components/shepherd-modal.svelte

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
<script>
22
import { makeOverlayPath } from '../utils/overlay-path.ts';
33
4-
let { element = $bindable(), openingProperties = $bindable() } = $props();
4+
let { openingProperties = $bindable() } = $props();
5+
let element = $state();
56
let modalIsVisible = $state(false);
6-
let rafId = undefined;
7+
let rafId = $state();
78
let pathDefinition = $derived(makeOverlayPath(openingProperties));
89
910
closeModalOpening();

0 commit comments

Comments
 (0)