[Z3] Initial support for Z3 Strings (v2) #516
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the bare minimum necessary to implement the symConstant function; in particular, we are not paying any attention to escaping whatsoever.
Collaborator
Author
|
@shingarov Any objections regarding this PR? |
Owner
|
Frankly, I would let this sit until someone with a special love for Z3 Strings commits to investing 1000+ hours of his life into this. The reason why we got into this rabbit-hole was as an emergency pseudo-solution to access "named things" through a custom type-level theory function, which we needed to access state from Jib. Is this branch's code needed for TR-Formal or Jib-Formal (e.g. for Prague demos)? |
Collaborator
Author
No. Okay, let it sleep then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is my evolution of PR #512 that fixes few issues I had with the original version. Nothing major though:
#isZ3String:and alike fromZ3Context. There's only one sender at the moment and - more importantly - none of the other nodes use this style. Instead, call toZ3API was moved to instance side ofZ3String.Z3Context currentshould not be used in instance methods ofZ3ContextedObjectsubclasses. Such objects know their context and should use it. Again, that's consistent with other nodes.#toZ3String,#asString,#cast:and so on).