Fix bug for XenServer

Author: Dingane Hlaluku

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

@@ -4878,29 +4878,24 @@ public UserVm createVirtualMachine(DeployVMCmd cmd) throws InsufficientCapacityE
         return vm;
     }
 
-    protected void setExtraConfigKeyValues(Long vmId, HypervisorType hypervisorType, String[] configData){
-        String re = (hypervisorType == HypervisorType.VMware)? "=": " ";
-        for (String config : configData) {
-            int index = config.indexOf(re);
-            String cmd = config.substring(0, index);
-            try {
-                userVmDetailsDao.addDetail(vmId, cmd,config.substring(index),true);
-            } catch (StringIndexOutOfBoundsException e) {
-                s_logger.error("Exception occurred: " + e.getMessage());
-                throw new CloudRuntimeException("Issue occurred during parsing of:" + config);
-            }
-        }
-    }
-
     protected void addExtraConfig(UserVm vm, Account caller, String extraConfig) {
         final Long callerId = caller.getId();
         final String decodedUrl = decodeExtraConfig(extraConfig);
         final HypervisorType hypervisorType = vm.getHypervisorType();
         final Long vmId = vm.getId();
         validateConfigOption(decodedUrl, callerId, hypervisorType);
-        if (hypervisorType == HypervisorType.VMware || hypervisorType == HypervisorType.XenServer) {
+        if (hypervisorType == HypervisorType.VMware) {
             String[] configDataArr = decodedUrl.split("\\r?\\n");
-            setExtraConfigKeyValues(vmId, hypervisorType, configDataArr);
+            for (String config : configDataArr) {
+                int index = config.indexOf("=");
+                String cmd = config.substring(0, index);
+                try {
+                    userVmDetailsDao.addDetail(vmId, cmd,config.substring(index),true);
+                } catch (StringIndexOutOfBoundsException e) {
+                    s_logger.error("Exception occurred: " + e.getMessage());
+                    throw new CloudRuntimeException("Issue occurred during parsing of:" + config);
+                }
+            }
         } else {
             userVmDetailsDao.addDetail(vm.getId(), ApiConstants.EXTRA_CONFIG, decodedUrl, true);
         }