Skip to content

Conversation

@jbirddog
Copy link
Contributor

To better support callers that already have a workflow in memory, added four new functions to read bpmn/dmn xml from a string or a file-like object. This prevents in memory callers from needing to know about/have a direct dependency on lxml.

@essweine
Copy link
Contributor

Can we just add the tests to the parser test file rather than creating an entirely new test? And consider naming the method add_bpmn_io (I realize this is kind of petty, but the shorter the name the better).

@jbirddog
Copy link
Contributor Author

Can we just add the tests to the parser test file rather than creating an entirely new test? And consider naming the method add_bpmn_io (I realize this is kind of petty, but the shorter the name the better).

Sounds good, updated.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@essweine essweine merged commit 299c261 into main Apr 26, 2023
@essweine essweine deleted the parser_funcs branch April 26, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants