rename KeepExisting->Preserve variant for leading match arm pipe config option#4305
Merged
topecongiro merged 1 commit intoJul 3, 2020
Conversation
topecongiro
approved these changes
Jul 3, 2020
topecongiro
left a comment
Contributor
There was a problem hiding this comment.
Seems good to me. Thank you!
Contributor
|
backported in #4305 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed briefly in #4090 (comment), but basically
Preservefeels like a better variant name thanKeepExisting.It's more succinct and direct, and though not terribly important, another minor benefit is that it also happens to be consistent with the equivalent config option values seen in other code formatting tools