Perform Sync check on static items in wf-check instead of during const checks#91251
Conversation
|
I'm not really familiar with wf-checking or how we usually split the work between wf-checking, type-checking, const-checking. This should not change which programs get accepted, right? It just changes diagnostics due to the check now running in a different 'phase'? |
yea, we never get to the body of the thing if wf-checking its signature fails
That's fine, I'll reroll the reviewer within the compiler team if/when you're ok with the behavioral changes of this PR. |
Didn't you just say there are none?^^ |
|
well... diagnostics are user-visible behaviour XD but yes, no new code compiles, no code stops compiling r? rust-lang/compiler |
|
@bors r+ |
|
@bors r+ |
|
📌 Commit 1869412 has been approved by |
…askrgr Rollup of 3 pull requests Successful merges: - rust-lang#91251 (Perform Sync check on static items in wf-check instead of during const checks) - rust-lang#91308 (Fix ICE when lowering `trait A where for<'a> Self: 'a`) - rust-lang#91319 (Change output path to {{build-base}} for rustdoc scrape_examples ui test) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
r? @RalfJung
This check is solely happening on the signature of the static item and not on its body, therefor it belongs into wf-checking instead of const checking.